Re: [Intel-gfx] [PATCH 4/9] drm/i915: add comment about pch pll enabling rules

2012-10-27 Thread Daniel Vetter
On Sat, Oct 27, 2012 at 2:15 PM, Paulo Zanoni wrote: > I'm not sure what's the problem with the current code. Could you > please explain a little bit more? After a brief look at > intel_enable_pch_pll and intel_disable_pch_pll it seems our code does > try to check the pll refcount and behave corre

Re: [Intel-gfx] [PATCH 4/9] drm/i915: add comment about pch pll enabling rules

2012-10-27 Thread Paulo Zanoni
Hi 2012/10/26 Daniel Vetter : > Atm we have a few funny issues where we enable/disable shared > pll clocks. To make it clear that we are not required to enable/ > disable the pch plls together with the other pch resources (and > so should keep it running when it's used by another pipe in > a share

[Intel-gfx] [PATCH 4/9] drm/i915: add comment about pch pll enabling rules

2012-10-26 Thread Daniel Vetter
Atm we have a few funny issues where we enable/disable shared pll clocks. To make it clear that we are not required to enable/ disable the pch plls together with the other pch resources (and so should keep it running when it's used by another pipe in a shared pll configuration) add a comment. This