Re: [Intel-gfx] [PATCH 4/8] drm/i915: Add a modeset power domain

2015-11-18 Thread Patrik Jakobsson
On Wed, Nov 18, 2015 at 10:02 AM, Daniel Vetter wrote: > On Sat, Nov 07, 2015 at 08:29:49AM +1000, Dave Airlie wrote: >> On 3 November 2015 at 22:31, Patrik Jakobsson >> wrote: >> > We need DC5/DC6 to be disabled around modesets to prevent confusing the >> > DMC. Also, we've run out of bits in th

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Add a modeset power domain

2015-11-18 Thread Daniel Vetter
On Sat, Nov 07, 2015 at 08:29:49AM +1000, Dave Airlie wrote: > On 3 November 2015 at 22:31, Patrik Jakobsson > wrote: > > We need DC5/DC6 to be disabled around modesets to prevent confusing the > > DMC. Also, we've run out of bits in the 32 bit power domain mask so now > > it's a 64 bit mask. > >

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Add a modeset power domain

2015-11-06 Thread Dave Airlie
On 3 November 2015 at 22:31, Patrik Jakobsson wrote: > We need DC5/DC6 to be disabled around modesets to prevent confusing the > DMC. Also, we've run out of bits in the 32 bit power domain mask so now > it's a 64 bit mask. > It was bad enough the original code used unsigned long so was different

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Add a modeset power domain

2015-11-06 Thread Daniel Stone
Hi, On 6 November 2015 at 13:53, Daniel Stone wrote: > On 5 November 2015 at 17:12, Patrik Jakobsson > wrote: >> On Thu, Nov 5, 2015 at 4:02 PM, Daniel Stone wrote: >>> On 3 November 2015 at 12:31, Patrik Jakobsson >>> wrote: We need DC5/DC6 to be disabled around modesets to prevent confu

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Add a modeset power domain

2015-11-06 Thread Daniel Stone
Hi, On 6 November 2015 at 14:17, Imre Deak wrote: > On pe, 2015-11-06 at 13:53 +, Daniel Stone wrote: >> On 5 November 2015 at 17:12, Patrik Jakobsson >> wrote: >> > Ah yes, we carry the mask around there as well. Thanks for catching >> > that. I like the move of POWER_DOMAIN_MODESET into pu

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Add a modeset power domain

2015-11-06 Thread Imre Deak
On pe, 2015-11-06 at 13:53 +, Daniel Stone wrote: > Hi, > > On 5 November 2015 at 17:12, Patrik Jakobsson > wrote: > > On Thu, Nov 5, 2015 at 4:02 PM, Daniel Stone > > wrote: > > > On 3 November 2015 at 12:31, Patrik Jakobsson > > > wrote: > > > > We need DC5/DC6 to be disabled around modes

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Add a modeset power domain

2015-11-06 Thread Daniel Stone
Hi, On 5 November 2015 at 17:12, Patrik Jakobsson wrote: > On Thu, Nov 5, 2015 at 4:02 PM, Daniel Stone wrote: >> On 3 November 2015 at 12:31, Patrik Jakobsson >> wrote: >>> We need DC5/DC6 to be disabled around modesets to prevent confusing the >>> DMC. Also, we've run out of bits in the 32 bi

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Add a modeset power domain

2015-11-05 Thread Patrik Jakobsson
On Thu, Nov 5, 2015 at 4:02 PM, Daniel Stone wrote: > Hi, > > On 3 November 2015 at 12:31, Patrik Jakobsson > wrote: >> We need DC5/DC6 to be disabled around modesets to prevent confusing the >> DMC. Also, we've run out of bits in the 32 bit power domain mask so now >> it's a 64 bit mask. > > The

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Add a modeset power domain

2015-11-05 Thread Daniel Stone
Hi, On 3 November 2015 at 12:31, Patrik Jakobsson wrote: > We need DC5/DC6 to be disabled around modesets to prevent confusing the > DMC. Also, we've run out of bits in the 32 bit power domain mask so now > it's a 64 bit mask. There are quite a lot of users in intel_display.c (search for put_dom

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Add a modeset power domain

2015-11-04 Thread Patrik Jakobsson
On Wed, Nov 4, 2015 at 6:29 PM, Ville Syrjälä wrote: > On Tue, Nov 03, 2015 at 01:31:10PM +0100, Patrik Jakobsson wrote: >> We need DC5/DC6 to be disabled around modesets to prevent confusing the >> DMC. Also, we've run out of bits in the 32 bit power domain mask so now >> it's a 64 bit mask. > >

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Add a modeset power domain

2015-11-04 Thread Ville Syrjälä
On Tue, Nov 03, 2015 at 01:31:10PM +0100, Patrik Jakobsson wrote: > We need DC5/DC6 to be disabled around modesets to prevent confusing the > DMC. Also, we've run out of bits in the 32 bit power domain mask so now > it's a 64 bit mask. We could get back 4 bits by squashing each 2 and 4 lane DDI po

[Intel-gfx] [PATCH 4/8] drm/i915: Add a modeset power domain

2015-11-03 Thread Patrik Jakobsson
We need DC5/DC6 to be disabled around modesets to prevent confusing the DMC. Also, we've run out of bits in the 32 bit power domain mask so now it's a 64 bit mask. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/i915/i915_debugfs.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 3 ++-