Re: [Intel-gfx] [PATCH 4/7] drm/i915: Remove irq-related FIXME in reset code

2015-03-02 Thread Daniel Vetter
On Fri, Feb 27, 2015 at 01:54:02PM -0800, Rodrigo Vivi wrote: > cool, thanks for the detailed explanation. > Reviewed-by: Rodrigo Vivi Queued for -next, thanks for the patch. -Daniel > > On Fri, Feb 27, 2015 at 6:04 AM, Daniel Vetter wrote: > > On Thu, Feb 26, 2015 at 05:11:16PM -0800, Rodrigo

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Remove irq-related FIXME in reset code

2015-02-27 Thread Rodrigo Vivi
cool, thanks for the detailed explanation. Reviewed-by: Rodrigo Vivi On Fri, Feb 27, 2015 at 6:04 AM, Daniel Vetter wrote: > On Thu, Feb 26, 2015 at 05:11:16PM -0800, Rodrigo Vivi wrote: >> I believe this patch is on the wrong series, right? > > It's in here since I've spotted the FIXME while re

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Remove irq-related FIXME in reset code

2015-02-27 Thread Daniel Vetter
On Thu, Feb 26, 2015 at 05:11:16PM -0800, Rodrigo Vivi wrote: > I believe this patch is on the wrong series, right? It's in here since I've spotted the FIXME while removing ums crap. > I'm afraid I don't know what was this race neither the two-step reset > to be able to review this comment remove

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Remove irq-related FIXME in reset code

2015-02-26 Thread Rodrigo Vivi
I believe this patch is on the wrong series, right? I'm afraid I don't know what was this race neither the two-step reset to be able to review this comment remove. Please give me some pointers to check that. On Mon, Feb 23, 2015 at 3:03 AM, Daniel Vetter wrote: > With the two-step reset counter

[Intel-gfx] [PATCH 4/7] drm/i915: Remove irq-related FIXME in reset code

2015-02-23 Thread Daniel Vetter
With the two-step reset counter increments which braket the actual reset code and the subsequent wake-up we're guaranteeing that all the lockless waiters _will_ be woken up. And since we unconditionally bail out of waits with -EAGAIN (or -EIO) in that case there is not risk of lost interrupt enabli