Re: [Intel-gfx] [PATCH 4/6] drm/i915: set ILK_DPFC_FENCE_YOFF to 0 on SNB

2015-07-14 Thread Paulo Zanoni
2015-07-09 14:39 GMT-03:00 Ville Syrjälä : > On Thu, Jul 09, 2015 at 02:31:15PM -0300, Paulo Zanoni wrote: >> 2015-07-09 14:22 GMT-03:00 Ville Syrjälä : >> > On Thu, Jul 09, 2015 at 07:10:04PM +0200, Daniel Vetter wrote: >> >> On Wed, Jul 08, 2015 at 05:58:57PM -0300, Paulo Zanoni wrote: >> >> > Fr

Re: [Intel-gfx] [PATCH 4/6] drm/i915: set ILK_DPFC_FENCE_YOFF to 0 on SNB

2015-07-09 Thread Ville Syrjälä
On Thu, Jul 09, 2015 at 02:31:15PM -0300, Paulo Zanoni wrote: > 2015-07-09 14:22 GMT-03:00 Ville Syrjälä : > > On Thu, Jul 09, 2015 at 07:10:04PM +0200, Daniel Vetter wrote: > >> On Wed, Jul 08, 2015 at 05:58:57PM -0300, Paulo Zanoni wrote: > >> > From: Paulo Zanoni > >> > > >> > The doc is pretty

Re: [Intel-gfx] [PATCH 4/6] drm/i915: set ILK_DPFC_FENCE_YOFF to 0 on SNB

2015-07-09 Thread Paulo Zanoni
2015-07-09 14:22 GMT-03:00 Ville Syrjälä : > On Thu, Jul 09, 2015 at 07:10:04PM +0200, Daniel Vetter wrote: >> On Wed, Jul 08, 2015 at 05:58:57PM -0300, Paulo Zanoni wrote: >> > From: Paulo Zanoni >> > >> > The doc is pretty clear that this register should be set to 0 on SNB. >> > We already write

Re: [Intel-gfx] [PATCH 4/6] drm/i915: set ILK_DPFC_FENCE_YOFF to 0 on SNB

2015-07-09 Thread Ville Syrjälä
On Thu, Jul 09, 2015 at 07:10:04PM +0200, Daniel Vetter wrote: > On Wed, Jul 08, 2015 at 05:58:57PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > The doc is pretty clear that this register should be set to 0 on SNB. > > We already write y_offset to DPFC_CPU_FENCE_OFFSET a few lines be

Re: [Intel-gfx] [PATCH 4/6] drm/i915: set ILK_DPFC_FENCE_YOFF to 0 on SNB

2015-07-09 Thread Paulo Zanoni
2015-07-09 14:15 GMT-03:00 Paulo Zanoni : > 2015-07-09 14:10 GMT-03:00 Daniel Vetter : >> On Wed, Jul 08, 2015 at 05:58:57PM -0300, Paulo Zanoni wrote: >>> From: Paulo Zanoni >>> >>> The doc is pretty clear that this register should be set to 0 on SNB. >>> We already write y_offset to DPFC_CPU_FEN

Re: [Intel-gfx] [PATCH 4/6] drm/i915: set ILK_DPFC_FENCE_YOFF to 0 on SNB

2015-07-09 Thread Paulo Zanoni
2015-07-09 14:10 GMT-03:00 Daniel Vetter : > On Wed, Jul 08, 2015 at 05:58:57PM -0300, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> The doc is pretty clear that this register should be set to 0 on SNB. >> We already write y_offset to DPFC_CPU_FENCE_OFFSET a few lines below. >> >> Signed-off-by:

Re: [Intel-gfx] [PATCH 4/6] drm/i915: set ILK_DPFC_FENCE_YOFF to 0 on SNB

2015-07-09 Thread Daniel Vetter
On Wed, Jul 08, 2015 at 05:58:57PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > The doc is pretty clear that this register should be set to 0 on SNB. > We already write y_offset to DPFC_CPU_FENCE_OFFSET a few lines below. > > Signed-off-by: Paulo Zanoni Hm, do we have testcases where we

[Intel-gfx] [PATCH 4/6] drm/i915: set ILK_DPFC_FENCE_YOFF to 0 on SNB

2015-07-08 Thread Paulo Zanoni
From: Paulo Zanoni The doc is pretty clear that this register should be set to 0 on SNB. We already write y_offset to DPFC_CPU_FENCE_OFFSET a few lines below. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_fbc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --gi