Re: [Intel-gfx] [PATCH 4/6] drm/i915/dp: use the new drm helpers for dp aux

2014-03-18 Thread Daniel Vetter
On Tue, Mar 18, 2014 at 3:02 PM, Rodrigo Vivi wrote: > Thanks for explanations Jani and Daniel. > > Feel free to use Reviewe-by: Rodrigo Vivi Thanks to patches & review, all pulled into a topic branch, will probably merge into dinq in a few days. -Daniel -- Daniel Vetter Software Engineer, Inte

Re: [Intel-gfx] [PATCH 4/6] drm/i915/dp: use the new drm helpers for dp aux

2014-03-18 Thread Rodrigo Vivi
Thanks for explanations Jani and Daniel. Feel free to use Reviewe-by: Rodrigo Vivi On Tue, Mar 18, 2014 at 7:54 AM, Jani Nikula wrote: > On Mon, 17 Mar 2014, Rodrigo Vivi wrote: >> On Fri, Mar 14, 2014 at 11:51 AM, Jani Nikula wrote: >>> Functionality remains largely the same as before. >>> >

Re: [Intel-gfx] [PATCH 4/6] drm/i915/dp: use the new drm helpers for dp aux

2014-03-18 Thread Jani Nikula
On Mon, 17 Mar 2014, Rodrigo Vivi wrote: > On Fri, Mar 14, 2014 at 11:51 AM, Jani Nikula wrote: >> Functionality remains largely the same as before. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/intel_dp.c | 257 >> +- >> drivers/gpu/drm/

Re: [Intel-gfx] [PATCH 4/6] drm/i915/dp: use the new drm helpers for dp aux

2014-03-17 Thread Jani Nikula
On Mon, 17 Mar 2014, Rodrigo Vivi wrote: > On Mon, Mar 17, 2014 at 11:08 AM, Rodrigo Vivi wrote: >> On Fri, Mar 14, 2014 at 11:51 AM, Jani Nikula wrote: >>> - if (!intel_dp_aux_native_read(intel_dp, DP_TEST_SINK_MISC, buf, 1)) >>> + if (drm_dp_dpcd_readb(&intel_dp->aux, DP_TEST_SINK_

Re: [Intel-gfx] [PATCH 4/6] drm/i915/dp: use the new drm helpers for dp aux

2014-03-17 Thread Rodrigo Vivi
On Mon, Mar 17, 2014 at 11:08 AM, Rodrigo Vivi wrote: > On Fri, Mar 14, 2014 at 11:51 AM, Jani Nikula wrote: >> Functionality remains largely the same as before. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/intel_dp.c | 257 >> +- >> dri

Re: [Intel-gfx] [PATCH 4/6] drm/i915/dp: use the new drm helpers for dp aux

2014-03-17 Thread Rodrigo Vivi
On Fri, Mar 14, 2014 at 11:51 AM, Jani Nikula wrote: > Functionality remains largely the same as before. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_dp.c | 257 > +- > drivers/gpu/drm/i915/intel_drv.h |1 + > 2 files changed, 116 i

[Intel-gfx] [PATCH 4/6] drm/i915/dp: use the new drm helpers for dp aux

2014-03-14 Thread Jani Nikula
Functionality remains largely the same as before. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dp.c | 257 +- drivers/gpu/drm/i915/intel_drv.h |1 + 2 files changed, 116 insertions(+), 142 deletions(-) diff --git a/drivers/gpu/drm/i915/inte