Re: [Intel-gfx] [PATCH 4/5] drm: Make HW_LOCK access functions optional.

2015-05-04 Thread Dave Airlie
> > Iirc it was in the ddx, and it was actually using the mmap code. Leftovers > from ums, but unfortunately X crashes if we take them away. If I recall > correctly nouveau was in staging still, but per Linus staging or not > doesn't matter when distros are shipping with the code already. I did dig

Re: [Intel-gfx] [PATCH 4/5] drm: Make HW_LOCK access functions optional.

2015-05-04 Thread Daniel Vetter
On Tue, Apr 28, 2015 at 01:29:21PM +, Antoine, Peter wrote: > On Tue, 2015-04-28 at 16:08 +0300, Ville Syrjälä wrote: > > On Tue, Apr 28, 2015 at 11:29:06AM +, Antoine, Peter wrote: > > > > > > diff --git a/include/drm/drmP.h b/include/drm/drmP.h index > > > > > > 62c40777..367e42f 100644

Re: [Intel-gfx] [PATCH 4/5] drm: Make HW_LOCK access functions optional.

2015-04-28 Thread Antoine, Peter
On Tue, 2015-04-28 at 16:08 +0300, Ville Syrjälä wrote: > On Tue, Apr 28, 2015 at 11:29:06AM +, Antoine, Peter wrote: > > > > > diff --git a/include/drm/drmP.h b/include/drm/drmP.h index > > > > > 62c40777..367e42f 100644 > > > > > --- a/include/drm/drmP.h > > > > > +++ b/include/drm/drmP.h >

Re: [Intel-gfx] [PATCH 4/5] drm: Make HW_LOCK access functions optional.

2015-04-28 Thread Ville Syrjälä
On Tue, Apr 28, 2015 at 11:29:06AM +, Antoine, Peter wrote: > > > > diff --git a/include/drm/drmP.h b/include/drm/drmP.h index > > > > 62c40777..367e42f 100644 > > > > --- a/include/drm/drmP.h > > > > +++ b/include/drm/drmP.h > > > > @@ -137,17 +137,18 @@ void drm_err(const char *format, ...);

Re: [Intel-gfx] [PATCH 4/5] drm: Make HW_LOCK access functions optional.

2015-04-28 Thread Antoine, Peter
.intel.com] > > Sent: Monday, April 27, 2015 6:04 PM > > To: Antoine, Peter > > Cc: intel-gfx@lists.freedesktop.org; airl...@redhat.com; > > dri-de...@lists.freedesktop.org; daniel.vet...@ffwll.ch > > Subject: Re: [Intel-gfx] [PATCH 4/5] drm: Make HW_LOCK access funct

Re: [Intel-gfx] [PATCH 4/5] drm: Make HW_LOCK access functions optional.

2015-04-28 Thread Ville Syrjälä
lists.freedesktop.org; airl...@redhat.com; > dri-de...@lists.freedesktop.org; daniel.vet...@ffwll.ch > Subject: Re: [Intel-gfx] [PATCH 4/5] drm: Make HW_LOCK access functions > optional. > > On Thu, Apr 23, 2015 at 03:07:57PM +0100, Peter Antoine wrote: > > As these functions ar

Re: [Intel-gfx] [PATCH 4/5] drm: Make HW_LOCK access functions optional.

2015-04-27 Thread Antoine, Peter
: [Intel-gfx] [PATCH 4/5] drm: Make HW_LOCK access functions optional. On Thu, Apr 23, 2015 at 03:07:57PM +0100, Peter Antoine wrote: > As these functions are only used by one driver and there are security > holes in these functions. Make the functions optional. > > Issue: VIZ-5485 >

Re: [Intel-gfx] [PATCH 4/5] drm: Make HW_LOCK access functions optional.

2015-04-27 Thread Ville Syrjälä
On Thu, Apr 23, 2015 at 03:07:57PM +0100, Peter Antoine wrote: > As these functions are only used by one driver and there are security holes > in these functions. Make the functions optional. > > Issue: VIZ-5485 > Signed-off-by: Peter Antoine > --- > drivers/gpu/drm/drm_lock.c| 6 ++

[Intel-gfx] [PATCH 4/5] drm: Make HW_LOCK access functions optional.

2015-04-23 Thread Peter Antoine
As these functions are only used by one driver and there are security holes in these functions. Make the functions optional. Issue: VIZ-5485 Signed-off-by: Peter Antoine --- drivers/gpu/drm/drm_lock.c| 6 ++ drivers/gpu/drm/i915/i915_dma.c | 3 +++ drivers/gpu/drm/nouveau