Re: [Intel-gfx] [PATCH 4/5] drm/i915: call kunmap_px on pt_vaddr

2016-04-19 Thread Mika Kuoppala
Joonas Lahtinen writes: > [ text/plain ] > On ti, 2016-04-12 at 16:57 +0100, Matthew Auld wrote: >> We need to kunmap pt_vaddr and not pt itself, otherwise we end up >> mapping a bunch of pages without ever unmapping them. >> > > It's always a good idea to use 'git blame' to figure out the bug >

Re: [Intel-gfx] [PATCH 4/5] drm/i915: call kunmap_px on pt_vaddr

2016-04-18 Thread Joonas Lahtinen
On ti, 2016-04-12 at 16:57 +0100, Matthew Auld wrote: > We need to kunmap pt_vaddr and not pt itself, otherwise we end up > mapping a bunch of pages without ever unmapping them. > It's always a good idea to use 'git blame' to figure out the bug inducing commit, and include that information + CC'i

[Intel-gfx] [PATCH 4/5] drm/i915: call kunmap_px on pt_vaddr

2016-04-12 Thread Matthew Auld
We need to kunmap pt_vaddr and not pt itself, otherwise we end up mapping a bunch of pages without ever unmapping them. Cc: Chris Wilson Cc: Joonas Lahtinen Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d