Re: [Intel-gfx] [PATCH 4/5] drm/i915: Let number of workarounds more clear

2014-09-30 Thread Rodrigo Vivi
so please, just ignore this patch anyway. On Fri, Sep 26, 2014 at 7:56 AM, Chris Wilson wrote: > On Fri, Sep 26, 2014 at 05:16:57PM +0300, Mika Kuoppala wrote: >> Jani Nikula writes: >> >> > On Fri, 26 Sep 2014, Mika Kuoppala wrote: >> >> Rodrigo Vivi writes: >> >> >> >>> This helps when inclu

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Let number of workarounds more clear

2014-09-26 Thread Chris Wilson
On Fri, Sep 26, 2014 at 05:16:57PM +0300, Mika Kuoppala wrote: > Jani Nikula writes: > > > On Fri, 26 Sep 2014, Mika Kuoppala wrote: > >> Rodrigo Vivi writes: > >> > >>> This helps when including or removing cs workarounds. > >>> Signed-off-by: Rodrigo Vivi > >>> --- > >>> drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Let number of workarounds more clear

2014-09-26 Thread Mika Kuoppala
Jani Nikula writes: > On Fri, 26 Sep 2014, Mika Kuoppala wrote: >> Rodrigo Vivi writes: >> >>> This helps when including or removing cs workarounds. >>> Signed-off-by: Rodrigo Vivi >>> --- >>> drivers/gpu/drm/i915/intel_ringbuffer.c | 16 >>> 1 file changed, 12 insertions(+),

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Let number of workarounds more clear

2014-09-26 Thread Damien Lespiau
On Fri, Sep 26, 2014 at 01:58:12PM +0100, Chris Wilson wrote: > > > I have a bit mixed feelings with this patch as I have tripped > > > around here myself recently. > > > > > > I think we should just drop this patch and use: > > > ret = intel_ring_begin(ring, 3 * ) on the subsequent > > > patches t

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Let number of workarounds more clear

2014-09-26 Thread Chris Wilson
On Fri, Sep 26, 2014 at 03:56:02PM +0300, Jani Nikula wrote: > On Fri, 26 Sep 2014, Mika Kuoppala wrote: > > Rodrigo Vivi writes: > > > >> This helps when including or removing cs workarounds. > >> Signed-off-by: Rodrigo Vivi > >> --- > >> drivers/gpu/drm/i915/intel_ringbuffer.c | 16 ++

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Let number of workarounds more clear

2014-09-26 Thread Jani Nikula
On Fri, 26 Sep 2014, Mika Kuoppala wrote: > Rodrigo Vivi writes: > >> This helps when including or removing cs workarounds. >> Signed-off-by: Rodrigo Vivi >> --- >> drivers/gpu/drm/i915/intel_ringbuffer.c | 16 >> 1 file changed, 12 insertions(+), 4 deletions(-) >> >> diff --gi

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Let number of workarounds more clear

2014-09-26 Thread Mika Kuoppala
Rodrigo Vivi writes: > This helps when including or removing cs workarounds. > Signed-off-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_ringbuffer.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c > b/driv

[Intel-gfx] [PATCH 4/5] drm/i915: Let number of workarounds more clear

2014-09-19 Thread Rodrigo Vivi
This helps when including or removing cs workarounds. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_ringbuffer.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c i