Re: [Intel-gfx] [PATCH 4/5] drm/i915: Implement fair lru eviction across both rings.

2010-08-04 Thread Chris Wilson
On Wed, 4 Aug 2010 22:16:58 +0200, Daniel Vetter wrote: > This way active buffers are scanned in retiring order, whereas your code > scans them in issuing order. IMHO the former is the fairer approach for > eviction when both rings are busy. I also think the code would look > slightly less scary ;

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Implement fair lru eviction across both rings.

2010-08-04 Thread Daniel Vetter
On Wed, Aug 04, 2010 at 12:20:36PM +0100, Chris Wilson wrote: > Based in a large part upon Daniel Vetter's implementation and adapted > for handling multiple rings in a single pass. I've thought some more about this and I'm not sold on the idea that your One Scan to Rule Them All is any fairer tha

[Intel-gfx] [PATCH 4/5] drm/i915: Implement fair lru eviction across both rings.

2010-08-04 Thread Chris Wilson
Based in a large part upon Daniel Vetter's implementation and adapted for handling multiple rings in a single pass. This should lead to better gtt usage and fixes the page-fault-of-doom triggered. The fairness is provided by scanning through the GTT space amalgamating space in rendering order. As