Re: [Intel-gfx] [PATCH 4/5] drm/i915/gmbus: alloc intel_gmbus dynamically

2022-03-04 Thread Jani Nikula
On Thu, 03 Mar 2022, Ville Syrjälä wrote: > On Thu, Mar 03, 2022 at 08:19:30PM +0200, Jani Nikula wrote: >> Allocate the individual intel_gmbus structs dynamically. This lets us >> hide struct intel_gmbus inside intel_gmbus.c completely. Also use the >> cleanup function on the error path to avoid

Re: [Intel-gfx] [PATCH 4/5] drm/i915/gmbus: alloc intel_gmbus dynamically

2022-03-03 Thread Ville Syrjälä
On Thu, Mar 03, 2022 at 08:19:30PM +0200, Jani Nikula wrote: > Allocate the individual intel_gmbus structs dynamically. This lets us > hide struct intel_gmbus inside intel_gmbus.c completely. Also use the > cleanup function on the error path to avoid duplication. > > Leave #include in i915_drv.h

[Intel-gfx] [PATCH 4/5] drm/i915/gmbus: alloc intel_gmbus dynamically

2022-03-03 Thread Jani Nikula
Allocate the individual intel_gmbus structs dynamically. This lets us hide struct intel_gmbus inside intel_gmbus.c completely. Also use the cleanup function on the error path to avoid duplication. Leave #include in i915_drv.h for now, as it pulls in a bunch of implicit dependencies. Signed-off-b