Re: [Intel-gfx] [PATCH 4/4] drm/i915: only call intel_prepare_ddi if HAS_DDI

2012-11-23 Thread Chris Wilson
On Fri, 23 Nov 2012 15:30:40 -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > In other words, move the check from inside the function to outside it. Don't agree with this last step. You can make the function tidier with an early return, but it is paramount that the high level sequence inside

[Intel-gfx] [PATCH 4/4] drm/i915: only call intel_prepare_ddi if HAS_DDI

2012-11-23 Thread Paulo Zanoni
From: Paulo Zanoni In other words, move the check from inside the function to outside it. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_ddi.c | 16 +++- drivers/gpu/drm/i915/intel_display.c | 3 ++- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/d