On Fri, Apr 4, 2014 at 11:11 PM, Paulo Zanoni wrote:
> Due to my past, I am not a person who should be reviewing these
> patches because I have a tendency to fear that a single variable
> rename will break everybody's machines at this point of the code :)
That's kinda why I want your opinion ;-)
2014-04-02 14:08 GMT-03:00 Jesse Barnes :
> Needs to happen after clock is running or it doesn't behave correctly.
>
> Signed-off-by: Jesse Barnes
> ---
> drivers/gpu/drm/i915/intel_hdmi.c |6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel
On Thu, 3 Apr 2014 22:55:24 +0200
Daniel Vetter wrote:
> On Thu, Apr 3, 2014 at 6:49 PM, Jesse Barnes wrote:
> >> > static bool intel_hdmi_get_hw_state(struct intel_encoder *encoder,
> >> > @@ -738,9 +736,13 @@ static void intel_enable_hdmi(struct intel_encoder
> >> > *encoder)
> >> > stru
On Thu, Apr 3, 2014 at 6:49 PM, Jesse Barnes wrote:
>> > static bool intel_hdmi_get_hw_state(struct intel_encoder *encoder,
>> > @@ -738,9 +736,13 @@ static void intel_enable_hdmi(struct intel_encoder
>> > *encoder)
>> > struct drm_i915_private *dev_priv = dev->dev_private;
>> > struct i
On Thu, 3 Apr 2014 17:19:56 +0200
Daniel Vetter wrote:
> On Wed, Apr 02, 2014 at 10:08:54AM -0700, Jesse Barnes wrote:
> > Needs to happen after clock is running or it doesn't behave correctly.
> >
> > Signed-off-by: Jesse Barnes
> > ---
> > drivers/gpu/drm/i915/intel_hdmi.c |6 --
> >
On Wed, Apr 02, 2014 at 10:08:54AM -0700, Jesse Barnes wrote:
> Needs to happen after clock is running or it doesn't behave correctly.
>
> Signed-off-by: Jesse Barnes
> ---
> drivers/gpu/drm/i915/intel_hdmi.c |6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/driv
On Wed, Apr 02, 2014 at 10:08:54AM -0700, Jesse Barnes wrote:
> Needs to happen after clock is running or it doesn't behave correctly.
Subject of the patch isn't correct. You enable it after the PLL, but
still before the port gets enabled. Which I believe is the order we
want. So you should just f
On Wed, 02 Apr 2014, Jesse Barnes wrote:
> Needs to happen after clock is running or it doesn't behave correctly.
Do you think this might fix some HDMI audio related bugs we have?
Jani.
>
> Signed-off-by: Jesse Barnes
> ---
> drivers/gpu/drm/i915/intel_hdmi.c |6 --
> 1 file changed,
Needs to happen after clock is running or it doesn't behave correctly.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_hdmi.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
b/drivers/gpu/drm/i915/intel_hdmi.c
index fb983
