Re: [Intel-gfx] [PATCH 4/4] drm/i915: WaFbcDisableDpfcClockGating only with fbc

2013-10-28 Thread Ben Widawsky
On Fri, Oct 25, 2013 at 03:24:12PM -0200, Paulo Zanoni wrote: > 2013/10/24 Ben Widawsky : > > We were turning this on for SNB regardless of whether or not we use FBC. > > We can save the slightest amount of power if we don't disable it when > > not using FBC. > > > > The workaround should be bit 9

Re: [Intel-gfx] [PATCH 4/4] drm/i915: WaFbcDisableDpfcClockGating only with fbc

2013-10-25 Thread Paulo Zanoni
2013/10/24 Ben Widawsky : > We were turning this on for SNB regardless of whether or not we use FBC. > We can save the slightest amount of power if we don't disable it when > not using FBC. > > The workaround should be bit 9 for SNB. First, see comment in patch 3. So you're removing the WA on ILK

[Intel-gfx] [PATCH 4/4] drm/i915: WaFbcDisableDpfcClockGating only with fbc

2013-10-24 Thread Ben Widawsky
We were turning this on for SNB regardless of whether or not we use FBC. We can save the slightest amount of power if we don't disable it when not using FBC. The workaround should be bit 9 for SNB. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/intel_pm.c | 25 +++-- 1