Re: [Intel-gfx] [PATCH 4/4] drm/i915: Get rid of acthd based guilty batch search

2014-01-30 Thread Chris Wilson
On Wed, Jan 29, 2014 at 01:44:34PM -0800, Ben Widawsky wrote: > Last word: As I've discussed with Chris too, I am overall a bit wary of > removing any use upon hardware for doing a lot of these error triage, > detection and collection functions. I really like that no matter how > bonghits our drive

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Get rid of acthd based guilty batch search

2014-01-29 Thread Ben Widawsky
On Wed, Jan 29, 2014 at 05:05:39PM +0200, Mika Kuoppala wrote: > As we seek the guilty batch using request and hangcheck > score, this code is not needed anymore. > > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_gem.c | 91 > ++- > 1 file

[Intel-gfx] [PATCH 4/4] drm/i915: Get rid of acthd based guilty batch search

2014-01-29 Thread Mika Kuoppala
As we seek the guilty batch using request and hangcheck score, this code is not needed anymore. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem.c | 91 ++- 1 file changed, 4 insertions(+), 87 deletions(-) diff --git a/drivers/gpu/drm/i915/i91