Re: [Intel-gfx] [PATCH 4/4] drm/i915: Extend skl+ crc sources with more planes

2019-02-20 Thread Ville Syrjälä
On Thu, Feb 14, 2019 at 06:07:05PM -0800, Dhinakaran Pandiyan wrote: > On Thu, 2019-02-14 at 21:22 +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > On skl the crc registers were extended to provide plane crcs > > for up to 7 planes. Add the new crc sources. > > > > The current code us

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Extend skl+ crc sources with more planes

2019-02-15 Thread Dhinakaran Pandiyan
On Thu, 2019-02-14 at 21:22 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > On skl the crc registers were extended to provide plane crcs > for up to 7 planes. Add the new crc sources. > > The current code uses the ivb+ register definitions for skl+ > which does happen to work as the plane1

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Extend skl+ crc sources with more planes

2019-02-14 Thread Rodrigo Vivi
On Thu, Feb 14, 2019 at 11:29:08PM +0200, Ville Syrjälä wrote: > On Thu, Feb 14, 2019 at 12:47:23PM -0800, Rodrigo Vivi wrote: > > On Thu, Feb 14, 2019 at 09:22:19PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > On skl the crc registers were extended to provide plane crcs > >

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Extend skl+ crc sources with more planes

2019-02-14 Thread Ville Syrjälä
On Thu, Feb 14, 2019 at 12:47:23PM -0800, Rodrigo Vivi wrote: > On Thu, Feb 14, 2019 at 09:22:19PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > On skl the crc registers were extended to provide plane crcs > > for up to 7 planes. Add the new crc sources. > > > > The current code us

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Extend skl+ crc sources with more planes

2019-02-14 Thread Rodrigo Vivi
On Thu, Feb 14, 2019 at 09:22:19PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > On skl the crc registers were extended to provide plane crcs > for up to 7 planes. Add the new crc sources. > > The current code uses the ivb+ register definitions for skl+ > which does happen to work as the

[Intel-gfx] [PATCH 4/4] drm/i915: Extend skl+ crc sources with more planes

2019-02-14 Thread Ville Syrjala
From: Ville Syrjälä On skl the crc registers were extended to provide plane crcs for up to 7 planes. Add the new crc sources. The current code uses the ivb+ register definitions for skl+ which does happen to work as the plane1, plane2, and dmux/pf bits happen the match what ivb+ had. So no bug i