Re: [Intel-gfx] [PATCH 30/66] drm/i915: Getter/setter for object attributes

2013-07-02 Thread Daniel Vetter
On Tue, Jul 2, 2013 at 6:51 PM, Ben Widawsky wrote: > On Tue, Jul 02, 2013 at 09:28:56AM +0200, Daniel Vetter wrote: >> On Mon, Jul 01, 2013 at 03:59:51PM -0700, Ben Widawsky wrote: >> > On Mon, Jul 01, 2013 at 09:08:58PM +0200, Daniel Vetter wrote: >> > > On Mon, Jul 1, 2013 at 8:43 PM, Daniel Ve

Re: [Intel-gfx] [PATCH 30/66] drm/i915: Getter/setter for object attributes

2013-07-02 Thread Ben Widawsky
On Tue, Jul 02, 2013 at 09:28:56AM +0200, Daniel Vetter wrote: > On Mon, Jul 01, 2013 at 03:59:51PM -0700, Ben Widawsky wrote: > > On Mon, Jul 01, 2013 at 09:08:58PM +0200, Daniel Vetter wrote: > > > On Mon, Jul 1, 2013 at 8:43 PM, Daniel Vetter wrote: > > > >> All of this is addressed in future p

Re: [Intel-gfx] [PATCH 30/66] drm/i915: Getter/setter for object attributes

2013-07-02 Thread Daniel Vetter
On Mon, Jul 01, 2013 at 03:59:51PM -0700, Ben Widawsky wrote: > On Mon, Jul 01, 2013 at 09:08:58PM +0200, Daniel Vetter wrote: > > On Mon, Jul 1, 2013 at 8:43 PM, Daniel Vetter wrote: > > >> All of this is addressed in future patches. As we've discussed, I think > > >> I'll have to respin it anywa

Re: [Intel-gfx] [PATCH 30/66] drm/i915: Getter/setter for object attributes

2013-07-01 Thread Ben Widawsky
On Mon, Jul 01, 2013 at 09:08:58PM +0200, Daniel Vetter wrote: > On Mon, Jul 1, 2013 at 8:43 PM, Daniel Vetter wrote: > >> All of this is addressed in future patches. As we've discussed, I think > >> I'll have to respin it anyway, so I'll name it as such upfront. To me it > >> felt a little weird

Re: [Intel-gfx] [PATCH 30/66] drm/i915: Getter/setter for object attributes

2013-07-01 Thread Daniel Vetter
On Mon, Jul 1, 2013 at 8:43 PM, Daniel Vetter wrote: >> All of this is addressed in future patches. As we've discussed, I think >> I'll have to respin it anyway, so I'll name it as such upfront. To me it >> felt a little weird to start calling things "ggtt" before I made the >> separation. > > I t

Re: [Intel-gfx] [PATCH 30/66] drm/i915: Getter/setter for object attributes

2013-07-01 Thread Daniel Vetter
On Mon, Jul 1, 2013 at 8:32 PM, Ben Widawsky wrote: > On Sun, Jun 30, 2013 at 03:00:05PM +0200, Daniel Vetter wrote: >> On Thu, Jun 27, 2013 at 04:30:31PM -0700, Ben Widawsky wrote: >> > This will be handy when we add VMs. It's not strictly, necessary, but it >> > will make the code much cleaner.

Re: [Intel-gfx] [PATCH 30/66] drm/i915: Getter/setter for object attributes

2013-07-01 Thread Ben Widawsky
On Sun, Jun 30, 2013 at 03:00:05PM +0200, Daniel Vetter wrote: > On Thu, Jun 27, 2013 at 04:30:31PM -0700, Ben Widawsky wrote: > > This will be handy when we add VMs. It's not strictly, necessary, but it > > will make the code much cleaner. > > > > Signed-off-by: Ben Widawsky > > You're going to

Re: [Intel-gfx] [PATCH 30/66] drm/i915: Getter/setter for object attributes

2013-06-30 Thread Daniel Vetter
On Thu, Jun 27, 2013 at 04:30:31PM -0700, Ben Widawsky wrote: > This will be handy when we add VMs. It's not strictly, necessary, but it > will make the code much cleaner. > > Signed-off-by: Ben Widawsky You're going to hate, but this is patch ordering fail. Imo this should be one of the very fi

[Intel-gfx] [PATCH 30/66] drm/i915: Getter/setter for object attributes

2013-06-27 Thread Ben Widawsky
This will be handy when we add VMs. It's not strictly, necessary, but it will make the code much cleaner. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_debugfs.c| 26 +-- drivers/gpu/drm/i915/i915_drv.h| 21 + drivers/gpu/drm/i915/i915_gem.c