Re: [Intel-gfx] [PATCH 3/7] drm/i915: don't read pp_ctrl_reg if we're suspended

2014-04-02 Thread Daniel Vetter
On Wed, Apr 02, 2014 at 01:35:22AM +0300, Imre Deak wrote: > On Wed, 2014-04-02 at 00:07 +0200, Daniel Vetter wrote: > > On Wed, Apr 02, 2014 at 12:42:50AM +0300, Imre Deak wrote: > > > On Wed, 2014-04-02 at 00:36 +0300, Imre Deak wrote: > > > > On Tue, 2014-04-01 at 18:04 -0300, Paulo Zanoni wrote

Re: [Intel-gfx] [PATCH 3/7] drm/i915: don't read pp_ctrl_reg if we're suspended

2014-04-01 Thread Imre Deak
On Wed, 2014-04-02 at 00:07 +0200, Daniel Vetter wrote: > On Wed, Apr 02, 2014 at 12:42:50AM +0300, Imre Deak wrote: > > On Wed, 2014-04-02 at 00:36 +0300, Imre Deak wrote: > > > On Tue, 2014-04-01 at 18:04 -0300, Paulo Zanoni wrote: > > > > 2014-04-01 17:52 GMT-03:00 Daniel Vetter : > > > > > On T

Re: [Intel-gfx] [PATCH 3/7] drm/i915: don't read pp_ctrl_reg if we're suspended

2014-04-01 Thread Daniel Vetter
On Wed, Apr 02, 2014 at 12:42:50AM +0300, Imre Deak wrote: > On Wed, 2014-04-02 at 00:36 +0300, Imre Deak wrote: > > On Tue, 2014-04-01 at 18:04 -0300, Paulo Zanoni wrote: > > > 2014-04-01 17:52 GMT-03:00 Daniel Vetter : > > > > On Tue, Apr 01, 2014 at 05:48:15PM -0300, Paulo Zanoni wrote: > > > >>

Re: [Intel-gfx] [PATCH 3/7] drm/i915: don't read pp_ctrl_reg if we're suspended

2014-04-01 Thread Imre Deak
On Wed, 2014-04-02 at 00:36 +0300, Imre Deak wrote: > On Tue, 2014-04-01 at 18:04 -0300, Paulo Zanoni wrote: > > 2014-04-01 17:52 GMT-03:00 Daniel Vetter : > > > On Tue, Apr 01, 2014 at 05:48:15PM -0300, Paulo Zanoni wrote: > > >> 2014-04-01 17:37 GMT-03:00 Daniel Vetter : > > >> > On Tue, Apr 01,

Re: [Intel-gfx] [PATCH 3/7] drm/i915: don't read pp_ctrl_reg if we're suspended

2014-04-01 Thread Imre Deak
On Tue, 2014-04-01 at 18:04 -0300, Paulo Zanoni wrote: > 2014-04-01 17:52 GMT-03:00 Daniel Vetter : > > On Tue, Apr 01, 2014 at 05:48:15PM -0300, Paulo Zanoni wrote: > >> 2014-04-01 17:37 GMT-03:00 Daniel Vetter : > >> > On Tue, Apr 01, 2014 at 02:55:09PM -0300, Paulo Zanoni wrote: > >> >> From: Pa

Re: [Intel-gfx] [PATCH 3/7] drm/i915: don't read pp_ctrl_reg if we're suspended

2014-04-01 Thread Paulo Zanoni
2014-04-01 17:52 GMT-03:00 Daniel Vetter : > On Tue, Apr 01, 2014 at 05:48:15PM -0300, Paulo Zanoni wrote: >> 2014-04-01 17:37 GMT-03:00 Daniel Vetter : >> > On Tue, Apr 01, 2014 at 02:55:09PM -0300, Paulo Zanoni wrote: >> >> From: Paulo Zanoni >> >> >> >> ... at edp_have_panel_vdd. Just return fa

Re: [Intel-gfx] [PATCH 3/7] drm/i915: don't read pp_ctrl_reg if we're suspended

2014-04-01 Thread Daniel Vetter
On Tue, Apr 01, 2014 at 05:48:15PM -0300, Paulo Zanoni wrote: > 2014-04-01 17:37 GMT-03:00 Daniel Vetter : > > On Tue, Apr 01, 2014 at 02:55:09PM -0300, Paulo Zanoni wrote: > >> From: Paulo Zanoni > >> > >> ... at edp_have_panel_vdd. Just return false, saying we don't have the > >> panel VDD since

Re: [Intel-gfx] [PATCH 3/7] drm/i915: don't read pp_ctrl_reg if we're suspended

2014-04-01 Thread Paulo Zanoni
2014-04-01 17:37 GMT-03:00 Daniel Vetter : > On Tue, Apr 01, 2014 at 02:55:09PM -0300, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> ... at edp_have_panel_vdd. Just return false, saying we don't have the >> panel VDD since the device is suspended. >> >> We started getting WARNs about this proble

Re: [Intel-gfx] [PATCH 3/7] drm/i915: don't read pp_ctrl_reg if we're suspended

2014-04-01 Thread Daniel Vetter
On Tue, Apr 01, 2014 at 02:55:09PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > ... at edp_have_panel_vdd. Just return false, saying we don't have the > panel VDD since the device is suspended. > > We started getting WARNs about this problem since the patch that > started checking if we'r

[Intel-gfx] [PATCH 3/7] drm/i915: don't read pp_ctrl_reg if we're suspended

2014-04-01 Thread Paulo Zanoni
From: Paulo Zanoni ... at edp_have_panel_vdd. Just return false, saying we don't have the panel VDD since the device is suspended. We started getting WARNs about this problem since the patch that started checking if we're suspended while reading registers. Testcase: igt/pm_pc8 Signed-off-by: Pa