Re: [Intel-gfx] [PATCH 3/6] drm/i915: keep declarations in i915_drv.h

2016-09-25 Thread Joonas Lahtinen
On to, 2016-09-22 at 13:50 +0200, Daniel Vetter wrote: > we also need to split up our headers I think, and I plan to start doing > that when extracting bits and pieces from intel_display.c. In drm core at > least having 1:1 between headers and source files seems to work rather > well. +1 on that,

Re: [Intel-gfx] [PATCH 3/6] drm/i915: keep declarations in i915_drv.h

2016-09-22 Thread Daniel Vetter
On Tue, Sep 20, 2016 at 12:58:20PM +0300, Jani Nikula wrote: > On Tue, 20 Sep 2016, Chris Wilson wrote: > > On Tue, Sep 20, 2016 at 11:57:06AM +0300, Jani Nikula wrote: > >> On Mon, 19 Sep 2016, Joonas Lahtinen > >> wrote: > >> > On to, 2016-09-15 at 16:28 +0300, Jani Nikula wrote: > >> >> Fix s

Re: [Intel-gfx] [PATCH 3/6] drm/i915: keep declarations in i915_drv.h

2016-09-22 Thread Jani Nikula
On Thu, 22 Sep 2016, Daniel Vetter wrote: > On Tue, Sep 20, 2016 at 12:58:20PM +0300, Jani Nikula wrote: >> On Tue, 20 Sep 2016, Chris Wilson wrote: >> > On Tue, Sep 20, 2016 at 11:57:06AM +0300, Jani Nikula wrote: >> >> On Mon, 19 Sep 2016, Joonas Lahtinen >> >> wrote: >> >> > On to, 2016-09-1

Re: [Intel-gfx] [PATCH 3/6] drm/i915: keep declarations in i915_drv.h

2016-09-20 Thread Jani Nikula
On Tue, 20 Sep 2016, Chris Wilson wrote: > On Tue, Sep 20, 2016 at 11:57:06AM +0300, Jani Nikula wrote: >> On Mon, 19 Sep 2016, Joonas Lahtinen wrote: >> > On to, 2016-09-15 at 16:28 +0300, Jani Nikula wrote: >> >> Fix sparse warnings: >> >> >> >> drivers/gpu/drm/i915/i915_drv.c:1179:5: warning:

Re: [Intel-gfx] [PATCH 3/6] drm/i915: keep declarations in i915_drv.h

2016-09-20 Thread Chris Wilson
On Tue, Sep 20, 2016 at 11:57:06AM +0300, Jani Nikula wrote: > On Mon, 19 Sep 2016, Joonas Lahtinen wrote: > > On to, 2016-09-15 at 16:28 +0300, Jani Nikula wrote: > >> Fix sparse warnings: > >> > >> drivers/gpu/drm/i915/i915_drv.c:1179:5: warning: symbol > >> 'i915_driver_load' was not declared.

Re: [Intel-gfx] [PATCH 3/6] drm/i915: keep declarations in i915_drv.h

2016-09-20 Thread Jani Nikula
On Mon, 19 Sep 2016, Joonas Lahtinen wrote: > On to, 2016-09-15 at 16:28 +0300, Jani Nikula wrote: >> Fix sparse warnings: >> >> drivers/gpu/drm/i915/i915_drv.c:1179:5: warning: symbol >> 'i915_driver_load' was not declared. Should it be static? >> >> drivers/gpu/drm/i915/i915_drv.c:1267:6: warn

Re: [Intel-gfx] [PATCH 3/6] drm/i915: keep declarations in i915_drv.h

2016-09-19 Thread Joonas Lahtinen
On to, 2016-09-15 at 16:28 +0300, Jani Nikula wrote: > Fix sparse warnings: > > drivers/gpu/drm/i915/i915_drv.c:1179:5: warning: symbol > 'i915_driver_load' was not declared. Should it be static? > > drivers/gpu/drm/i915/i915_drv.c:1267:6: warning: symbol > 'i915_driver_unload' was not declared.

[Intel-gfx] [PATCH 3/6] drm/i915: keep declarations in i915_drv.h

2016-09-15 Thread Jani Nikula
Fix sparse warnings: drivers/gpu/drm/i915/i915_drv.c:1179:5: warning: symbol 'i915_driver_load' was not declared. Should it be static? drivers/gpu/drm/i915/i915_drv.c:1267:6: warning: symbol 'i915_driver_unload' was not declared. Should it be static? drivers/gpu/drm/i915/i915_drv.c:2444:25: warn