[Intel-gfx] [PATCH 3/5] drm/i915: forcewake struct mutex locking fixes

2011-04-25 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_debugfs.c |5 + drivers/gpu/drm/i915/intel_display.c |9 + 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 3cb0722..30bf

Re: [Intel-gfx] [PATCH 3/5] drm/i915: forcewake struct mutex locking fixes

2011-04-22 Thread Chris Wilson
On Fri, 22 Apr 2011 09:20:17 -0700, Ben Widawsky wrote: > I don't understand what you're asking for. I'm pretty convinced I need > the mutex protected intel_update_fbc, because the call trace could be: > > intel_update_fbc() > intel_enable_fbc() > ironlake_enable_fbc() > sandybridge_blit_fbc_upda

Re: [Intel-gfx] [PATCH 3/5] drm/i915: forcewake struct mutex locking fixes

2011-04-22 Thread Ben Widawsky
On Fri, Apr 22, 2011 at 09:20:17AM -0700, Ben Widawsky wrote: > On Thu, Apr 21, 2011 at 07:18:24AM +0100, Chris Wilson wrote: > > On Wed, 20 Apr 2011 16:53:17 -0700, Ben Widawsky wrote: > > > > > > Signed-off-by: Ben Widawsky > > > > Just to annoy you, this needs to be split up into the various

Re: [Intel-gfx] [PATCH 3/5] drm/i915: forcewake struct mutex locking fixes

2011-04-22 Thread Ben Widawsky
On Thu, Apr 21, 2011 at 07:18:24AM +0100, Chris Wilson wrote: > On Wed, 20 Apr 2011 16:53:17 -0700, Ben Widawsky wrote: > > > > Signed-off-by: Ben Widawsky > > Just to annoy you, this needs to be split up into the various categories > of fixes. Because... > > > static void ironlake_crtc_dpms(

Re: [Intel-gfx] [PATCH 3/5] drm/i915: forcewake struct mutex locking fixes

2011-04-20 Thread Chris Wilson
On Wed, 20 Apr 2011 16:53:17 -0700, Ben Widawsky wrote: > > Signed-off-by: Ben Widawsky Just to annoy you, this needs to be split up into the various categories of fixes. Because... > static void ironlake_crtc_dpms(struct drm_crtc *crtc, int mode) > @@ -3067,9 +3074,12 @@ static void i9xx_crt

[Intel-gfx] [PATCH 3/5] drm/i915: forcewake struct mutex locking fixes

2011-04-20 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_debugfs.c |2 ++ drivers/gpu/drm/i915/intel_display.c | 12 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 3cb0722..94b3