Re: [Intel-gfx] [PATCH 3/5] drm/i915: Extract gen6 aliasing ppgtt code

2013-01-29 Thread Ben Widawsky
On Tue, Jan 29, 2013 at 01:55:46PM +0100, Daniel Vetter wrote: > On Fri, Jan 25, 2013 at 04:41:05PM -0800, Ben Widawsky wrote: > > This refactor clearly identifies the GEN specific portion of the aliased > > ppgtt code. Aside from some of the gen specific parts being extracted, > > it also preps us

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Extract gen6 aliasing ppgtt code

2013-01-29 Thread Daniel Vetter
On Fri, Jan 25, 2013 at 04:41:05PM -0800, Ben Widawsky wrote: > This refactor clearly identifies the GEN specific portion of the aliased > ppgtt code. Aside from some of the gen specific parts being extracted, > it also preps us for an upcoming patch that pulls out the size, which > has some nice b

[Intel-gfx] [PATCH 3/5] drm/i915: Extract gen6 aliasing ppgtt code

2013-01-25 Thread Ben Widawsky
This refactor clearly identifies the GEN specific portion of the aliased ppgtt code. Aside from some of the gen specific parts being extracted, it also preps us for an upcoming patch that pulls out the size, which has some nice benefits. v2: Fix wonky error handling (Chris) Signed-off-by: Ben Wid

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Extract gen6 aliasing ppgtt code

2012-12-29 Thread Chris Wilson
On Sat, 29 Dec 2012 11:45:09 -0800, Ben Widawsky wrote: > On Sat, 29 Dec 2012 11:49:01 + > Chris Wilson wrote: > > > On Fri, 28 Dec 2012 20:27:27 -0800, Ben Widawsky > > wrote: > > > This refactor clearly identifies the GEN specific portion of the > > > aliased ppgtt code. Aside from some o

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Extract gen6 aliasing ppgtt code

2012-12-29 Thread Ben Widawsky
On Sat, 29 Dec 2012 11:49:01 + Chris Wilson wrote: > On Fri, 28 Dec 2012 20:27:27 -0800, Ben Widawsky > wrote: > > This refactor clearly identifies the GEN specific portion of the > > aliased ppgtt code. Aside from some of the gen specific parts being > > extracted, it also preps us for an u

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Extract gen6 aliasing ppgtt code

2012-12-29 Thread Chris Wilson
On Fri, 28 Dec 2012 20:27:27 -0800, Ben Widawsky wrote: > This refactor clearly identifies the GEN specific portion of the aliased > ppgtt code. Aside from some of the gen specific parts being extracted, > it also preps us for an upcoming patch that pulls out the size, which > has some nice benefi

[Intel-gfx] [PATCH 3/5] drm/i915: Extract gen6 aliasing ppgtt code

2012-12-28 Thread Ben Widawsky
This refactor clearly identifies the GEN specific portion of the aliased ppgtt code. Aside from some of the gen specific parts being extracted, it also preps us for an upcoming patch that pulls out the size, which has some nice benefits. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_