[Intel-gfx] [PATCH 3/4] drm/i915: unify no_fbc_reason message printing

2015-06-12 Thread Paulo Zanoni
From: Paulo Zanoni This commit has two main advantages: simplify intel_fbc_update() and deduplicate the strings. v2: - Rebase due to changes on P1. - set_no_fbc_reason() can now return void (Chris). Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_debugfs.c | 49 +++

Re: [Intel-gfx] [PATCH 3/4] drm/i915: unify no_fbc_reason message printing

2015-06-12 Thread Damien Lespiau
On Thu, Jun 11, 2015 at 04:02:26PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > This commit has two main advantages: simplify intel_fbc_update() > and deduplicate the strings. > > Signed-off-by: Paulo Zanoni I had some things around that topic as well in feb. May be of interest: http:/

Re: [Intel-gfx] [PATCH 3/4] drm/i915: unify no_fbc_reason message printing

2015-06-12 Thread Chris Wilson
On Thu, Jun 11, 2015 at 04:02:26PM -0300, Paulo Zanoni wrote: > @@ -439,6 +472,8 @@ static bool set_no_fbc_reason(struct drm_i915_private > *dev_priv, > return false; > > dev_priv->fbc.no_fbc_reason = reason; > + DRM_DEBUG_KMS("Disabling FBC: %s\n", intel_no_fbc_reason_st

[Intel-gfx] [PATCH 3/4] drm/i915: unify no_fbc_reason message printing

2015-06-11 Thread Paulo Zanoni
From: Paulo Zanoni This commit has two main advantages: simplify intel_fbc_update() and deduplicate the strings. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_debugfs.c | 49 +++ drivers/gpu/drm/i915/intel_drv.h| 1 + drivers/gpu/drm/i915/intel_fbc.c