Re: [Intel-gfx] [PATCH 3/4] drm/i915: extract constant offset setting

2011-10-13 Thread Ben Widawsky
On Thu, Oct 13, 2011 at 10:46:29AM +0200, Daniel Vetter wrote: > On Wed, Oct 12, 2011 at 03:56:21PM -0700, Ben Widawsky wrote: > > Simple refactor. > > > > Signed-off-by: Ben Widawsky > > Imo you can fold this in with the fix. Usually it's good to separate fixes > from refactoring, but it this s

Re: [Intel-gfx] [PATCH 3/4] drm/i915: extract constant offset setting

2011-10-13 Thread Daniel Vetter
On Wed, Oct 12, 2011 at 03:56:21PM -0700, Ben Widawsky wrote: > Simple refactor. > > Signed-off-by: Ben Widawsky Imo you can fold this in with the fix. Usually it's good to separate fixes from refactoring, but it this special case of just moving around code blocks, it doesn't add anything. > --

[Intel-gfx] [PATCH 3/4] drm/i915: extract constant offset setting

2011-10-12 Thread Ben Widawsky
Simple refactor. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 82 1 files changed, 46 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c index 1ee1872