Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use unsigned long for obj->user_pin_count

2013-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2013 at 10:56 AM, Ville Syrjälä wrote: > On Wed, Oct 09, 2013 at 09:23:53PM +0200, Daniel Vetter wrote: >> At least on linux sizeof(long) == sizeof(void*) and the thinking >> is that you can grab about as many references as there's memory. > > Well, there can be more memory than th

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use unsigned long for obj->user_pin_count

2013-10-10 Thread Ville Syrjälä
On Wed, Oct 09, 2013 at 09:23:53PM +0200, Daniel Vetter wrote: > At least on linux sizeof(long) == sizeof(void*) and the thinking > is that you can grab about as many references as there's memory. Well, there can be more memory than there is address space. Unchecked counters always leave me a bit

[Intel-gfx] [PATCH 3/4] drm/i915: Use unsigned long for obj->user_pin_count

2013-10-09 Thread Daniel Vetter
At least on linux sizeof(long) == sizeof(void*) and the thinking is that you can grab about as many references as there's memory. Doesn't really matter, just a bit of OCD since the fixed size data type in a pure in-kernel datastructure look off. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/