Re: [Intel-gfx] [PATCH 3/4] drm/i915: Stop requiring PLL index == PLL ID

2022-09-22 Thread Ville Syrjälä
On Thu, Sep 22, 2022 at 06:46:30PM +0300, Jani Nikula wrote: > On Wed, 21 Sep 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > There's no good reason to keep around this PLL index == PLL ID > > footgun. Get rid of it. > > > > Both i915->shared_dplls[] and state->shared_dpll[] are indexe

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Stop requiring PLL index == PLL ID

2022-09-22 Thread Jani Nikula
On Wed, 21 Sep 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > There's no good reason to keep around this PLL index == PLL ID > footgun. Get rid of it. > > Both i915->shared_dplls[] and state->shared_dpll[] are indexed > by the same thing now, which is just the index we get at > initializati

[Intel-gfx] [PATCH 3/4] drm/i915: Stop requiring PLL index == PLL ID

2022-09-21 Thread Ville Syrjala
From: Ville Syrjälä There's no good reason to keep around this PLL index == PLL ID footgun. Get rid of it. Both i915->shared_dplls[] and state->shared_dpll[] are indexed by the same thing now, which is just the index we get at initialization from dpll_mgr->dpll_info[]. The rest is all about PLL