Re: [Intel-gfx] [PATCH 3/4] drm/i915: Bail if plane/crtc init fails

2016-11-04 Thread Chris Wilson
On Fri, Nov 04, 2016 at 11:07:26PM +0200, Ville Syrjälä wrote: > On Fri, Nov 04, 2016 at 08:48:21PM +, Chris Wilson wrote: > > On Tue, Oct 25, 2016 at 06:58:02PM +0300, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > Due to the plane->index not getting readjust

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Bail if plane/crtc init fails

2016-11-04 Thread Ville Syrjälä
On Fri, Nov 04, 2016 at 08:48:21PM +, Chris Wilson wrote: > On Tue, Oct 25, 2016 at 06:58:02PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Due to the plane->index not getting readjusted in drm_plane_cleanup(), > > we can't continue initialization of some plane/

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Bail if plane/crtc init fails

2016-11-04 Thread Chris Wilson
On Tue, Oct 25, 2016 at 06:58:02PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Due to the plane->index not getting readjusted in drm_plane_cleanup(), > we can't continue initialization of some plane/crtc init fails. > Well, we sort of could I suppose if we left all initi

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Bail if plane/crtc init fails

2016-10-27 Thread Daniel Vetter
On Tue, Oct 25, 2016 at 06:58:02PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Due to the plane->index not getting readjusted in drm_plane_cleanup(), > we can't continue initialization of some plane/crtc init fails. > Well, we sort of could I suppose if we left all initi

[Intel-gfx] [PATCH 3/4] drm/i915: Bail if plane/crtc init fails

2016-10-25 Thread ville . syrjala
From: Ville Syrjälä Due to the plane->index not getting readjusted in drm_plane_cleanup(), we can't continue initialization of some plane/crtc init fails. Well, we sort of could I suppose if we left all initialized planes on the list, but that would expose those planes to userspace as well. But