Re: [Intel-gfx] [PATCH 3/4] drm/i915/icl: Only grab TC ports when using it

2018-11-05 Thread Imre Deak
On Sat, Nov 03, 2018 at 01:41:12AM +0200, Souza, Jose wrote: > On Sat, 2018-11-03 at 01:06 +0200, Imre Deak wrote: > > On Fri, Nov 02, 2018 at 01:39:23PM -0700, José Roberto de Souza > > wrote: > > > When suspending or unloading the driver, it needs to release the > > > TC ports so HW can change it

Re: [Intel-gfx] [PATCH 3/4] drm/i915/icl: Only grab TC ports when using it

2018-11-02 Thread Souza, Jose
On Sat, 2018-11-03 at 01:06 +0200, Imre Deak wrote: > On Fri, Nov 02, 2018 at 01:39:23PM -0700, José Roberto de Souza > wrote: > > When suspending or unloading the driver, it needs to release the > > TC ports so HW can change it state without wait for driver > > handshake. > > Spec also state that

Re: [Intel-gfx] [PATCH 3/4] drm/i915/icl: Only grab TC ports when using it

2018-11-02 Thread Imre Deak
On Fri, Nov 02, 2018 at 01:39:23PM -0700, José Roberto de Souza wrote: > When suspending or unloading the driver, it needs to release the > TC ports so HW can change it state without wait for driver handshake. > Spec also state that if the port is not used by driver it should > release TC access, s

[Intel-gfx] [PATCH 3/4] drm/i915/icl: Only grab TC ports when using it

2018-11-02 Thread José Roberto de Souza
When suspending or unloading the driver, it needs to release the TC ports so HW can change it state without wait for driver handshake. Spec also state that if the port is not used by driver it should release TC access, so here only grabbing control of the TC ports and marking as unsafe when aux pow