Re: [Intel-gfx] [PATCH 3/3] intel: Add a function for the new register read ioctl.

2012-08-02 Thread Ben Widawsky
On 2012-08-02 11:29, Eric Anholt wrote: --- I'm not sure if this is the API we want or not. Getting your value back through an out parameter sucks. On the other hand, the 3d driver wants to be able to use the error value to detect a supported kernel. My other API thought would be for reg_rea

[Intel-gfx] [PATCH 3/3] intel: Add a function for the new register read ioctl.

2012-08-02 Thread Eric Anholt
--- I'm not sure if this is the API we want or not. Getting your value back through an out parameter sucks. On the other hand, the 3d driver wants to be able to use the error value to detect a supported kernel. My other API thought would be for reg_read() to return the value and whine if an erro