[Intel-gfx] [PATCH 3/3] drm/i915: check gtfifodbg after possibly failed writes

2012-02-09 Thread Ben Widawsky
If we don't have a sufficient number of free entries in the FIFO, we proceed to do a write anyway. With this check we should have a clue if that write actually failed or not. After some discussion with Daniel Vetter regarding his original complaint, we agreed upon this. Signed-off-by: Ben Widawsk

Re: [Intel-gfx] [PATCH 3/3] drm/i915: check gtfifodbg after possibly failed writes

2012-02-08 Thread Ben Widawsky
On 02/08/2012 11:28 AM, Chris Wilson wrote: > On Wed, 8 Feb 2012 11:15:58 +0100, Daniel Vetter wrote: >> Bit a bikeshed comment, but I prefer explicit control flow instead of >> playing tricks with the short-circuiting behaviour of &&. Mind if you can >> change that, too? > > Whilst we're on the

Re: [Intel-gfx] [PATCH 3/3] drm/i915: check gtfifodbg after possibly failed writes

2012-02-08 Thread Chris Wilson
On Wed, 8 Feb 2012 11:15:58 +0100, Daniel Vetter wrote: > Bit a bikeshed comment, but I prefer explicit control flow instead of > playing tricks with the short-circuiting behaviour of &&. Mind if you can > change that, too? Whilst we're on the subject of bikesheds, having an explicit tracepoint f

Re: [Intel-gfx] [PATCH 3/3] drm/i915: check gtfifodbg after possibly failed writes

2012-02-08 Thread Daniel Vetter
On Tue, Feb 07, 2012 at 04:21:50PM +0100, Ben Widawsky wrote: > If we don't have a sufficient number of free entries in the FIFO, we > proceed to do a write anyway. With this check we should have a clue if > that write actually failed or not. > > After some discussion with Daniel Vetter regarding

[Intel-gfx] [PATCH 3/3] drm/i915: check gtfifodbg after possibly failed writes

2012-02-07 Thread Ben Widawsky
If we don't have a sufficient number of free entries in the FIFO, we proceed to do a write anyway. With this check we should have a clue if that write actually failed or not. After some discussion with Daniel Vetter regarding his original complaint, we agreed upon this. Signed-off-by: Ben Widawsk