Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use new INSTDONE registers

2012-08-16 Thread Ben Widawsky
On Thu, 16 Aug 2012 09:31:51 +0300 Jani Nikula wrote: > On Thu, 16 Aug 2012, Ben Widawsky wrote: > > Using the extracted INSTDONE reading, and our new register definitions, > > update our hangcheck and error collection to use it. > > Hi Ben, please find some nitpicks below... > > BR, > Jani. >

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use new INSTDONE registers

2012-08-16 Thread Jani Nikula
On Thu, 16 Aug 2012, Ben Widawsky wrote: > Using the extracted INSTDONE reading, and our new register definitions, > update our hangcheck and error collection to use it. Hi Ben, please find some nitpicks below... BR, Jani. > > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_debu

[Intel-gfx] [PATCH 3/3] drm/i915: Use new INSTDONE registers

2012-08-15 Thread Ben Widawsky
Using the extracted INSTDONE reading, and our new register definitions, update our hangcheck and error collection to use it. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_debugfs.c | 8 --- drivers/gpu/drm/i915/i915_drv.h | 5 ++-- drivers/gpu/drm/i915/i915_irq.c | 47 +