Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-06-17 Thread Daniel Vetter
On Tue, Jun 16, 2015 at 05:07:46PM +0100, Chris Wilson wrote: > On Tue, Jun 16, 2015 at 04:10:19PM +0100, Tvrtko Ursulin wrote: > > > > > > On 06/16/2015 02:53 PM, Chris Wilson wrote: > > >On Tue, Jun 16, 2015 at 02:32:40PM +0100, Tvrtko Ursulin wrote: > > >> > > >>On 06/16/2015 12:48 PM, Chris W

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-06-16 Thread Chris Wilson
On Tue, Jun 16, 2015 at 04:10:19PM +0100, Tvrtko Ursulin wrote: > > > On 06/16/2015 02:53 PM, Chris Wilson wrote: > >On Tue, Jun 16, 2015 at 02:32:40PM +0100, Tvrtko Ursulin wrote: > >> > >>On 06/16/2015 12:48 PM, Chris Wilson wrote: > >>>On Tue, Jun 16, 2015 at 12:31:23PM +0100, Tvrtko Ursulin w

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-06-16 Thread Tvrtko Ursulin
On 06/16/2015 02:53 PM, Chris Wilson wrote: On Tue, Jun 16, 2015 at 02:32:40PM +0100, Tvrtko Ursulin wrote: On 06/16/2015 12:48 PM, Chris Wilson wrote: On Tue, Jun 16, 2015 at 12:31:23PM +0100, Tvrtko Ursulin wrote: That is partially correct, I do see it as problematic since I assumed someo

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-06-16 Thread Chris Wilson
On Tue, Jun 16, 2015 at 02:32:40PM +0100, Tvrtko Ursulin wrote: > > On 06/16/2015 12:48 PM, Chris Wilson wrote: > >On Tue, Jun 16, 2015 at 12:31:23PM +0100, Tvrtko Ursulin wrote: > >>That is partially correct, I do see it as problematic since I > >>assumed someone will modeset with this fb/object

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-06-16 Thread Tvrtko Ursulin
On 06/16/2015 12:48 PM, Chris Wilson wrote: On Tue, Jun 16, 2015 at 12:31:23PM +0100, Tvrtko Ursulin wrote: That is partially correct, I do see it as problematic since I assumed someone will modeset with this fb/object at some point, and there will be state available then, which won't have the

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-06-16 Thread Chris Wilson
On Tue, Jun 16, 2015 at 12:31:23PM +0100, Tvrtko Ursulin wrote: > > On 06/16/2015 12:22 PM, Chris Wilson wrote: > >On Tue, Jun 16, 2015 at 12:18:49PM +0100, Tvrtko Ursulin wrote: > >> > >>On 06/16/2015 12:02 PM, Chris Wilson wrote: > >>>On Tue, Jun 16, 2015 at 11:17:11AM +0100, Tvrtko Ursulin wrot

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-06-16 Thread Tvrtko Ursulin
On 06/16/2015 12:22 PM, Chris Wilson wrote: On Tue, Jun 16, 2015 at 12:18:49PM +0100, Tvrtko Ursulin wrote: On 06/16/2015 12:02 PM, Chris Wilson wrote: On Tue, Jun 16, 2015 at 11:17:11AM +0100, Tvrtko Ursulin wrote: On 05/28/2015 03:09 PM, Daniel Vetter wrote: On Thu, May 28, 2015 at 01:36

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-06-16 Thread Chris Wilson
On Tue, Jun 16, 2015 at 12:18:49PM +0100, Tvrtko Ursulin wrote: > > On 06/16/2015 12:02 PM, Chris Wilson wrote: > >On Tue, Jun 16, 2015 at 11:17:11AM +0100, Tvrtko Ursulin wrote: > >> > >>On 05/28/2015 03:09 PM, Daniel Vetter wrote: > >>>On Thu, May 28, 2015 at 01:36:54PM +0100, Chris Wilson wrote

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-06-16 Thread Tvrtko Ursulin
On 06/16/2015 12:02 PM, Chris Wilson wrote: On Tue, Jun 16, 2015 at 11:17:11AM +0100, Tvrtko Ursulin wrote: On 05/28/2015 03:09 PM, Daniel Vetter wrote: On Thu, May 28, 2015 at 01:36:54PM +0100, Chris Wilson wrote: On Thu, May 28, 2015 at 02:24:40PM +0200, Daniel Vetter wrote: On Thu, May 2

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-06-16 Thread Chris Wilson
On Tue, Jun 16, 2015 at 12:02:00PM +0100, Chris Wilson wrote: > fbdev is a little special. All that we actually require is a plain > ggtt_pin to ensure that the fb is still around for panics. We can leave > the plane state in modesetting. We have have full control over the > struct we associated wi

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-06-16 Thread Chris Wilson
On Tue, Jun 16, 2015 at 11:17:11AM +0100, Tvrtko Ursulin wrote: > > On 05/28/2015 03:09 PM, Daniel Vetter wrote: > >On Thu, May 28, 2015 at 01:36:54PM +0100, Chris Wilson wrote: > >>On Thu, May 28, 2015 at 02:24:40PM +0200, Daniel Vetter wrote: > >>>On Thu, May 28, 2015 at 09:58:30AM +0100, Tvrtko

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-06-16 Thread Tvrtko Ursulin
On 05/28/2015 03:09 PM, Daniel Vetter wrote: On Thu, May 28, 2015 at 01:36:54PM +0100, Chris Wilson wrote: On Thu, May 28, 2015 at 02:24:40PM +0200, Daniel Vetter wrote: On Thu, May 28, 2015 at 09:58:30AM +0100, Tvrtko Ursulin wrote: On 05/27/2015 10:15 PM, Chris Wilson wrote: On Wed, May 2

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-05-28 Thread Daniel Vetter
On Thu, May 28, 2015 at 01:36:54PM +0100, Chris Wilson wrote: > On Thu, May 28, 2015 at 02:24:40PM +0200, Daniel Vetter wrote: > > On Thu, May 28, 2015 at 09:58:30AM +0100, Tvrtko Ursulin wrote: > > > > > > On 05/27/2015 10:15 PM, Chris Wilson wrote: > > > >On Wed, May 27, 2015 at 10:52:34AM +0100

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-05-28 Thread Chris Wilson
On Thu, May 28, 2015 at 02:24:40PM +0200, Daniel Vetter wrote: > On Thu, May 28, 2015 at 09:58:30AM +0100, Tvrtko Ursulin wrote: > > > > On 05/27/2015 10:15 PM, Chris Wilson wrote: > > >On Wed, May 27, 2015 at 10:52:34AM +0100, Tvrtko Ursulin wrote: > > >>From: Tvrtko Ursulin > > >> > > >>These a

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-05-28 Thread Daniel Vetter
On Thu, May 28, 2015 at 09:58:30AM +0100, Tvrtko Ursulin wrote: > > On 05/27/2015 10:15 PM, Chris Wilson wrote: > >On Wed, May 27, 2015 at 10:52:34AM +0100, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>These are the display call sites so should use the proper helper. > >> > >>Also requ

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-05-28 Thread Tvrtko Ursulin
On 05/27/2015 10:15 PM, Chris Wilson wrote: On Wed, May 27, 2015 at 10:52:34AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin These are the display call sites so should use the proper helper. Also requires intel_plane_obj_offset to assume normal view when plane pointer is not available.

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-05-27 Thread Chris Wilson
On Wed, May 27, 2015 at 10:52:34AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > These are the display call sites so should use the proper helper. > > Also requires intel_plane_obj_offset to assume normal view when > plane pointer is not available. Eugh. If only the plane stored the o

[Intel-gfx] [PATCH 3/3] drm/i915: Use intel_plane_obj_offset from more places

2015-05-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin These are the display call sites so should use the proper helper. Also requires intel_plane_obj_offset to assume normal view when plane pointer is not available. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c | 8 +--- drivers/gpu/drm/i915/inte