Re: [Intel-gfx] [PATCH 3/3] drm/i915: Remove the vma from the drm_mm if binding fails

2017-02-27 Thread Chris Wilson
On Mon, Feb 27, 2017 at 02:02:00PM +0200, Joonas Lahtinen wrote: > On la, 2017-02-25 at 23:25 +, Chris Wilson wrote: > > As we track whether a vma has been inserted into the drm_mm using the > > vma->flags, if we fail to bind the vma into the GTT we do not update > > those bits and will attempt

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Remove the vma from the drm_mm if binding fails

2017-02-27 Thread Joonas Lahtinen
On la, 2017-02-25 at 23:25 +, Chris Wilson wrote: > As we track whether a vma has been inserted into the drm_mm using the > vma->flags, if we fail to bind the vma into the GTT we do not update > those bits and will attempt to reinsert the vma into the drm_mm on > future passes. To prevent that,

[Intel-gfx] [PATCH 3/3] drm/i915: Remove the vma from the drm_mm if binding fails

2017-02-25 Thread Chris Wilson
As we track whether a vma has been inserted into the drm_mm using the vma->flags, if we fail to bind the vma into the GTT we do not update those bits and will attempt to reinsert the vma into the drm_mm on future passes. To prevent that, we want to unwind i915_vma_insert() if we fail in our attempt