Re: [Intel-gfx] [PATCH 3/3] drm/i915: Flush the workqueue before draining

2019-07-04 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-07-04 11:22:17) >> Chris Wilson writes: >> >> > Trying to drain a workqueue while we may still be adding to it from >> > background tasks is, according to kernel/workqueue.c, verboten. So, add >> > a flush_workqueue() at the start of our cleanu

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Flush the workqueue before draining

2019-07-04 Thread Chris Wilson
Quoting Mika Kuoppala (2019-07-04 11:22:17) > Chris Wilson writes: > > > Trying to drain a workqueue while we may still be adding to it from > > background tasks is, according to kernel/workqueue.c, verboten. So, add > > a flush_workqueue() at the start of our cleanup procedure. > > I don't get

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Flush the workqueue before draining

2019-07-04 Thread Mika Kuoppala
Chris Wilson writes: > Trying to drain a workqueue while we may still be adding to it from > background tasks is, according to kernel/workqueue.c, verboten. So, add > a flush_workqueue() at the start of our cleanup procedure. I don't get it. drain_workqueue does it's own flushing. -Mika > > Sig

[Intel-gfx] [PATCH 3/3] drm/i915: Flush the workqueue before draining

2019-07-03 Thread Chris Wilson
Trying to drain a workqueue while we may still be adding to it from background tasks is, according to kernel/workqueue.c, verboten. So, add a flush_workqueue() at the start of our cleanup procedure. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h | 1 + 1 file changed, 1 insertio