Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-07-07 Thread Daniel Vetter
On Mon, Jun 23, 2014 at 02:13:55PM +0100, Chris Wilson wrote: > On Mon, Jun 23, 2014 at 01:09:37PM +, Mateo Lozano, Oscar wrote: > > So far, yes, but that´s only because I artificially made intel_lrc.c > > self-contained, as Daniel requested. What if we need to execute commands > > from somew

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-07-07 Thread Daniel Vetter
t: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring > > submission mechanism > > There are 3 cases of non-execbuffer submissions that I can think of: flips, > > render state, and clear-buffer (proposed patches on the list). I wonder if > > the > > right app

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-26 Thread Mateo Lozano, Oscar
> -Original Message- > From: Jesse Barnes [mailto:jbar...@virtuousgeek.org] > Sent: Tuesday, June 24, 2014 6:20 PM > To: Chris Wilson > Cc: Mateo Lozano, Oscar; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring >

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-24 Thread Jesse Barnes
On Mon, 23 Jun 2014 14:13:55 +0100 Chris Wilson wrote: > On Mon, Jun 23, 2014 at 01:09:37PM +, Mateo Lozano, Oscar wrote: > > So far, yes, but that´s only because I artificially made > > intel_lrc.c self-contained, as Daniel requested. What if we need to > > execute commands from somewhere el

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-24 Thread Volkin, Bradley D
On Tue, Jun 24, 2014 at 04:45:05AM -0700, Mateo Lozano, Oscar wrote: > Ok, let´s try to extract something positive out of all this. > > OPTION A (Ben´s proposal): > > > I think the only solution for what Chris is asking for is to implement this > > as 1 > > context per engine, as opposed to 1 co

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-24 Thread Mateo Lozano, Oscar
> -Original Message- > From: Volkin, Bradley D > Sent: Monday, June 23, 2014 8:10 PM > To: Mateo Lozano, Oscar > Cc: Chris Wilson; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring > submission mechanism > >

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-24 Thread Mateo Lozano, Oscar
Ok, let´s try to extract something positive out of all this. OPTION A (Ben´s proposal): > I think the only solution for what Chris is asking for is to implement this > as 1 > context per engine, as opposed to 1 context with a context object per > engine. As you correctly stated, I think we all a

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Ben Widawsky
ts.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring > > submission mechanism > > > > On Mon, Jun 23, 2014 at 01:36:07PM +, Mateo Lozano, Oscar wrote: > > > > -Original Message- > > > > From: Chris Wil

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Volkin, Bradley D
ts.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring > > submission mechanism > > > > On Mon, Jun 23, 2014 at 01:36:07PM +, Mateo Lozano, Oscar wrote: > > > > -Original Message- > > > > From: Chris Wil

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Mateo Lozano, Oscar
ar > > > Cc: Volkin, Bradley D; intel-gfx@lists.freedesktop.org > > > Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical > > > ring submission mechanism > > > > > > On Mon, Jun 23, 2014 at 01:18:35PM +, Mateo Lozano, Oscar

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Chris Wilson
ts.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring > > submission mechanism > > > > On Mon, Jun 23, 2014 at 01:18:35PM +, Mateo Lozano, Oscar wrote: > > > > -Original Message- > > > > From: Chris Wil

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Mateo Lozano, Oscar
ar > > > Cc: Volkin, Bradley D; intel-gfx@lists.freedesktop.org > > > Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical > > > ring submission mechanism > > > > > > On Mon, Jun 23, 2014 at 01:09:37PM +, Mateo Lozano, Oscar > wrote:

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Chris Wilson
ts.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring > > submission mechanism > > > > On Mon, Jun 23, 2014 at 01:09:37PM +, Mateo Lozano, Oscar wrote: > > > So far, yes, but that´s only because I artificially made intel_lrc

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Mateo Lozano, Oscar
> -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Monday, June 23, 2014 2:14 PM > To: Mateo Lozano, Oscar > Cc: Volkin, Bradley D; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Chris Wilson
On Mon, Jun 23, 2014 at 01:09:37PM +, Mateo Lozano, Oscar wrote: > So far, yes, but that´s only because I artificially made intel_lrc.c > self-contained, as Daniel requested. What if we need to execute commands from > somewhere else, like in intel_gen7_queue_flip()? > > And this takes me to

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-23 Thread Mateo Lozano, Oscar
> -Original Message- > From: Volkin, Bradley D > Sent: Friday, June 20, 2014 10:01 PM > To: Mateo Lozano, Oscar > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring > submission mechanism > > On Fri, Jun 1

Re: [Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-20 Thread Volkin, Bradley D
On Fri, Jun 13, 2014 at 08:37:44AM -0700, oscar.ma...@intel.com wrote: > From: Oscar Mateo > > Well, new-ish: if all this code looks familiar, that's because it's > a clone of the existing submission mechanism (with some modifications > here and there to adapt it to LRCs and Execlists). > > And

[Intel-gfx] [PATCH 26/53] drm/i915/bdw: New logical ring submission mechanism

2014-06-13 Thread oscar . mateo
From: Oscar Mateo Well, new-ish: if all this code looks familiar, that's because it's a clone of the existing submission mechanism (with some modifications here and there to adapt it to LRCs and Execlists). And why did we do this? Execlists offer several advantages, like control over when the GP