Re: [Intel-gfx] [PATCH 25/29] drm/i915: detect digital outputs on Haswell

2012-04-15 Thread Daniel Vetter
On Fri, Apr 13, 2012 at 09:37:44PM -0300, Eugeni Dodonov wrote: > On Fri, Apr 13, 2012 at 18:17, Chris Wilson wrote: > > > We're starting to get to ridiculous levels of indention. Break the PCH > > detection of SDVO/HDMI outputs into its own routine, and perhaps further > > down in architectures?

Re: [Intel-gfx] [PATCH 25/29] drm/i915: detect digital outputs on Haswell

2012-04-13 Thread Eugeni Dodonov
On Fri, Apr 13, 2012 at 18:17, Chris Wilson wrote: > We're starting to get to ridiculous levels of indention. Break the PCH > detection of SDVO/HDMI outputs into its own routine, and perhaps further > down in architectures? > Yes, both intel_display and intel_hdmi get too overcomplex with those p

Re: [Intel-gfx] [PATCH 25/29] drm/i915: detect digital outputs on Haswell

2012-04-13 Thread Chris Wilson
On Fri, 13 Apr 2012 17:09:01 -0300, Eugeni Dodonov wrote: > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index bdc22f5..1524966 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -8743,26 +8743,45

[Intel-gfx] [PATCH 25/29] drm/i915: detect digital outputs on Haswell

2012-04-13 Thread Eugeni Dodonov
Digital port detection on Haswell is indicated by the presence of a bit in DDI_BUF_CTL for port A, and by a different register for ports B, C and D. So we check for those bits during the initialization time and let the hdmi function know about those. Note that this bit does not indicates whether t