Re: [Intel-gfx] [PATCH 24/66] drm/i915: Move aliasing_ppgtt

2013-07-01 Thread Daniel Vetter
On Mon, Jul 1, 2013 at 9:48 PM, Ben Widawsky wrote: >> Full ppgtt otoh need the address space of course. >> >> The above structure layout would allow that. It means that aliasing >> ppgtt will stick out a bit like a sore thumb but imo that's ok since >> it really _is_ a bit an odd thing. I've just

Re: [Intel-gfx] [PATCH 24/66] drm/i915: Move aliasing_ppgtt

2013-07-01 Thread Ben Widawsky
On Mon, Jul 01, 2013 at 09:06:20PM +0200, Daniel Vetter wrote: > On Mon, Jul 1, 2013 at 8:52 PM, Ben Widawsky wrote: > >> One thing which looks a bit peculiar at the end is that struct > >> i915_hw_ppgtt is actually used as the real ppgtt object (since it > >> subclases i915_address space). My ori

Re: [Intel-gfx] [PATCH 24/66] drm/i915: Move aliasing_ppgtt

2013-07-01 Thread Daniel Vetter
On Mon, Jul 1, 2013 at 8:52 PM, Ben Widawsky wrote: >> One thing which looks a bit peculiar at the end is that struct >> i915_hw_ppgtt is actually used as the real ppgtt object (since it >> subclases i915_address space). My original plan was that we'll add a new >> struct i915_ppgtt { >> str

Re: [Intel-gfx] [PATCH 24/66] drm/i915: Move aliasing_ppgtt

2013-07-01 Thread Ben Widawsky
On Sun, Jun 30, 2013 at 03:27:44PM +0200, Daniel Vetter wrote: > On Thu, Jun 27, 2013 at 04:30:25PM -0700, Ben Widawsky wrote: > > for file in `ls drivers/gpu/drm/i915/*.c` ; do > > sed -i "s/mm.aliasing/gtt.aliasing/" $file; > > done > > Commit message should explain _why_ we do something. Ag

Re: [Intel-gfx] [PATCH 24/66] drm/i915: Move aliasing_ppgtt

2013-06-30 Thread Daniel Vetter
On Thu, Jun 27, 2013 at 04:30:25PM -0700, Ben Widawsky wrote: > for file in `ls drivers/gpu/drm/i915/*.c` ; do > sed -i "s/mm.aliasing/gtt.aliasing/" $file; > done Commit message should explain _why_ we do something. Again I'm asking since I'm unclear about how things fit all together and wh

[Intel-gfx] [PATCH 24/66] drm/i915: Move aliasing_ppgtt

2013-06-27 Thread Ben Widawsky
for file in `ls drivers/gpu/drm/i915/*.c` ; do sed -i "s/mm.aliasing/gtt.aliasing/" $file; done Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_debugfs.c| 4 ++-- drivers/gpu/drm/i915/i915_dma.c| 2 +- drivers/gpu/drm/i915/i915_drv.h| 6 +++---