Re: [Intel-gfx] [PATCH 24/51] drm/i915: Add i915_sched_engine destroy vfunc

2021-07-20 Thread Matthew Brost
On Tue, Jul 20, 2021 at 12:55:08PM -0700, John Harrison wrote: > On 7/16/2021 13:16, Matthew Brost wrote: > > This help the backends clean up when the schedule engine object gets > help -> helps. Although, I would say it's more like 'this is required to > allow backend specific cleanup'. It doesn't

Re: [Intel-gfx] [PATCH 24/51] drm/i915: Add i915_sched_engine destroy vfunc

2021-07-20 Thread John Harrison
On 7/16/2021 13:16, Matthew Brost wrote: This help the backends clean up when the schedule engine object gets help -> helps. Although, I would say it's more like 'this is required to allow backend specific cleanup'. It doesn't just make life a bit easier, it allows us to not leak stuff and/or d

[Intel-gfx] [PATCH 24/51] drm/i915: Add i915_sched_engine destroy vfunc

2021-07-16 Thread Matthew Brost
This help the backends clean up when the schedule engine object gets destroyed. Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/i915_scheduler.c | 3 ++- drivers/gpu/drm/i915/i915_scheduler.h | 4 +--- drivers/gpu/drm/i915/i915_scheduler_types.h | 5 + 3 files changed, 8 in