Re: [Intel-gfx] [PATCH 21/29] drm/i915: mm_list is per VMA

2013-08-08 Thread Ben Widawsky
On Thu, Aug 08, 2013 at 08:46:46AM +0200, Daniel Vetter wrote: > On Thu, Aug 8, 2013 at 6:32 AM, Ben Widawsky wrote: > > You killed a BUG in i915_gem_retire_requests_ring, shouldn't that be a WARN > > or are you in the business of completely killing assertions now :p? > > Yeah, and my little com

Re: [Intel-gfx] [PATCH 21/29] drm/i915: mm_list is per VMA

2013-08-07 Thread Daniel Vetter
On Thu, Aug 8, 2013 at 6:32 AM, Ben Widawsky wrote: > You killed a BUG in i915_gem_retire_requests_ring, shouldn't that be a WARN > or are you in the business of completely killing assertions now :p? Yeah, and my little commit message annotation even explained that it's fully redundant since the

Re: [Intel-gfx] [PATCH 21/29] drm/i915: mm_list is per VMA

2013-08-07 Thread Ben Widawsky
On Wed, Aug 07, 2013 at 10:52:14PM +0200, Daniel Vetter wrote: > On Tue, Aug 06, 2013 at 05:28:06PM -0700, Ben Widawsky wrote: > > On Tue, Aug 06, 2013 at 09:38:41PM +0200, Daniel Vetter wrote: > > > On Wed, Jul 31, 2013 at 05:00:14PM -0700, Ben Widawsky wrote: > > > > formerly: "drm/i915: Create V

Re: [Intel-gfx] [PATCH 21/29] drm/i915: mm_list is per VMA

2013-08-07 Thread Daniel Vetter
On Tue, Aug 06, 2013 at 05:28:06PM -0700, Ben Widawsky wrote: > On Tue, Aug 06, 2013 at 09:38:41PM +0200, Daniel Vetter wrote: > > On Wed, Jul 31, 2013 at 05:00:14PM -0700, Ben Widawsky wrote: > > > formerly: "drm/i915: Create VMAs (part 5) - move mm_list" > > > > > > The mm_list is used for the a

Re: [Intel-gfx] [PATCH 21/29] drm/i915: mm_list is per VMA

2013-08-06 Thread Ben Widawsky
On Tue, Aug 06, 2013 at 09:38:41PM +0200, Daniel Vetter wrote: > On Wed, Jul 31, 2013 at 05:00:14PM -0700, Ben Widawsky wrote: > > formerly: "drm/i915: Create VMAs (part 5) - move mm_list" > > > > The mm_list is used for the active/inactive LRUs. Since those LRUs are > > per address space, the lin

Re: [Intel-gfx] [PATCH 21/29] drm/i915: mm_list is per VMA

2013-08-06 Thread Daniel Vetter
On Wed, Jul 31, 2013 at 05:00:14PM -0700, Ben Widawsky wrote: > formerly: "drm/i915: Create VMAs (part 5) - move mm_list" > > The mm_list is used for the active/inactive LRUs. Since those LRUs are > per address space, the link should be per VMx . > > Because we'll only ever have 1 VMA before this

[Intel-gfx] [PATCH 21/29] drm/i915: mm_list is per VMA

2013-07-31 Thread Ben Widawsky
formerly: "drm/i915: Create VMAs (part 5) - move mm_list" The mm_list is used for the active/inactive LRUs. Since those LRUs are per address space, the link should be per VMx . Because we'll only ever have 1 VMA before this point, it's not incorrect to defer this change until this point in the pa