Re: [Intel-gfx] [PATCH 21/24] drm/i915: unify PM interrupt preinstall sequence

2013-07-04 Thread Daniel Vetter
On Fri, Jun 28, 2013 at 10:26:37AM -0700, Ben Widawsky wrote: > On Wed, Jun 12, 2013 at 01:37:23PM +0200, Daniel Vetter wrote: > > Since the addition of VECS we have a slightly different enable > > sequence for PM interrupts on ivb/hsw vs snb and vlv. Usually that > > will end up in hard to track d

Re: [Intel-gfx] [PATCH 21/24] drm/i915: unify PM interrupt preinstall sequence

2013-06-28 Thread Ben Widawsky
On Wed, Jun 12, 2013 at 01:37:23PM +0200, Daniel Vetter wrote: > Since the addition of VECS we have a slightly different enable > sequence for PM interrupts on ivb/hsw vs snb and vlv. Usually that > will end up in hard to track down surprises. > > Hence unifiy things and since we have copies of th

[Intel-gfx] [PATCH 21/24] drm/i915: unify PM interrupt preinstall sequence

2013-06-12 Thread Daniel Vetter
Since the addition of VECS we have a slightly different enable sequence for PM interrupts on ivb/hsw vs snb and vlv. Usually that will end up in hard to track down surprises. Hence unifiy things and since we have copies of this code in 3 places now, extract it into its own little helper. Signed-o