Re: [Intel-gfx] [PATCH 2/9] drm/i915: Extract node allocation from bind

On Wed, May 07, 2014 at 05:55:00PM +0100, Chris Wilson wrote: > On Wed, May 07, 2014 at 09:00:16AM -0700, Ben Widawsky wrote: > > On Wed, May 07, 2014 at 04:53:08PM +0100, Chris Wilson wrote: > > > On Wed, May 07, 2014 at 08:45:38AM -0700, Ben Widawsky wrote: > > > > Hmm. I really don't see what's

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Extract node allocation from bind

On Wed, May 07, 2014 at 09:00:16AM -0700, Ben Widawsky wrote: > On Wed, May 07, 2014 at 04:53:08PM +0100, Chris Wilson wrote: > > On Wed, May 07, 2014 at 08:45:38AM -0700, Ben Widawsky wrote: > > > Hmm. I really don't see what's actually upsetting. Can you be a bit more > > > explicit about what's

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Extract node allocation from bind

On Wed, May 07, 2014 at 04:53:08PM +0100, Chris Wilson wrote: > On Wed, May 07, 2014 at 08:45:38AM -0700, Ben Widawsky wrote: > > On Wed, May 07, 2014 at 08:02:38AM +0100, Chris Wilson wrote: > > > On Tue, May 06, 2014 at 10:21:31PM -0700, Ben Widawsky wrote: > > > > The DRM node allocation code wa

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Extract node allocation from bind

On Wed, May 07, 2014 at 08:45:38AM -0700, Ben Widawsky wrote: > On Wed, May 07, 2014 at 08:02:38AM +0100, Chris Wilson wrote: > > On Tue, May 06, 2014 at 10:21:31PM -0700, Ben Widawsky wrote: > > > The DRM node allocation code was already a bit of an ugly bit of code > > > within a complex function

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Extract node allocation from bind

On Wed, May 07, 2014 at 08:02:38AM +0100, Chris Wilson wrote: > On Tue, May 06, 2014 at 10:21:31PM -0700, Ben Widawsky wrote: > > The DRM node allocation code was already a bit of an ugly bit of code > > within a complex function. Removing it serves the purpose of cleaning > > the function up. More

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Extract node allocation from bind

On Tue, May 06, 2014 at 10:21:31PM -0700, Ben Widawsky wrote: > The DRM node allocation code was already a bit of an ugly bit of code > within a complex function. Removing it serves the purpose of cleaning > the function up. More importantly, it provides a way to have a > preallocated (address spac

[Intel-gfx] [PATCH 2/9] drm/i915: Extract node allocation from bind

The DRM node allocation code was already a bit of an ugly bit of code within a complex function. Removing it serves the purpose of cleaning the function up. More importantly, it provides a way to have a preallocated (address space) VMA to easily skip this code. Something we're very likely to need.