Re: [Intel-gfx] [PATCH 2/8] drm/i915: Change get_existing_crtc_state to old state

2017-08-01 Thread Mahesh Kumar
On Tuesday 01 August 2017 01:23 PM, Maarten Lankhorst wrote: Hey, Op 01-08-17 om 08:46 schreef Mahesh Kumar: Hi, As per my understanding "get_existing_*_state == get_new_*_state" It looks like you are trying to use currently available unused wrapper for completely different purpose. But IM

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Change get_existing_crtc_state to old state

2017-08-01 Thread Maarten Lankhorst
Hey, Op 01-08-17 om 08:46 schreef Mahesh Kumar: > Hi, > > As per my understanding "get_existing_*_state == get_new_*_state" > > It looks like you are trying to use currently available unused wrapper for > completely different purpose. But IMHO you should create a new wrapper for > get_old_state

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Change get_existing_crtc_state to old state

2017-07-31 Thread Mahesh Kumar
Hi, As per my understanding "get_existing_*_state == get_new_*_state" It looks like you are trying to use currently available unused wrapper for completely different purpose. But IMHO you should create a new wrapper for get_old_state & this should be renamed to get_new_state. :) -Mahesh O

[Intel-gfx] [PATCH 2/8] drm/i915: Change get_existing_crtc_state to old state

2017-07-20 Thread Maarten Lankhorst
get_existing_crtc_state is currently unused, but the next commit needs to access the old intel state. Rename this and use this as convenience wrapper. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_drv.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/d