Re: [Intel-gfx] [PATCH 2/7] drm/i915: Fixup Oops in the pipe config computation

2013-04-12 Thread Daniel Vetter
On Fri, Apr 12, 2013 at 11:46 AM, Chris Wilson wrote: > On Thu, Apr 11, 2013 at 04:29:05PM +0200, Daniel Vetter wrote: >> Yet again our current confusion between doing the modeset globally, >> but only having the new parameters for one crtc at a time. >> >> This time things blew up when restoring

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Fixup Oops in the pipe config computation

2013-04-12 Thread Chris Wilson
On Thu, Apr 11, 2013 at 04:29:05PM +0200, Daniel Vetter wrote: > Yet again our current confusion between doing the modeset globally, > but only having the new parameters for one crtc at a time. > > This time things blew up when restoring modes in the switchless resume > code - intel_modeset_affect

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Fixup Oops in the pipe config computation

2013-04-12 Thread Daniel Vetter
On Thu, Apr 11, 2013 at 11:09:00PM +0200, Daniel Vetter wrote: > On Thu, Apr 11, 2013 at 04:29:05PM +0200, Daniel Vetter wrote: > > Yet again our current confusion between doing the modeset globally, > > but only having the new parameters for one crtc at a time. > > > > This time things blew up wh

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Fixup Oops in the pipe config computation

2013-04-11 Thread Daniel Vetter
On Thu, Apr 11, 2013 at 04:29:05PM +0200, Daniel Vetter wrote: > Yet again our current confusion between doing the modeset globally, > but only having the new parameters for one crtc at a time. > > This time things blew up when restoring modes in the switchless resume > code - intel_modeset_affect

[Intel-gfx] [PATCH 2/7] drm/i915: Fixup Oops in the pipe config computation

2013-04-11 Thread Daniel Vetter
Yet again our current confusion between doing the modeset globally, but only having the new parameters for one crtc at a time. This time things blew up when restoring modes in the switchless resume code - intel_modeset_affected_pipes figured out that pipe 2 should be restored, but since pipe 1 was