Re: [Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-25 10:30:51) > Related, there could be potential to unify i915_request_retire_upto and > ring_retire_requests. Latter could pass in NULL as the upto request, > just the completed check would need to be different depending on the mode. Also remember that _upto is t

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-25 Thread Tvrtko Ursulin
On 24/04/2018 15:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-24 15:46:49) On 24/04/2018 14:14, Chris Wilson wrote: In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we ma

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-24 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-24 15:46:49) > > On 24/04/2018 14:14, Chris Wilson wrote: > > In the next patch, rings are the central timeline as requests may jump > > between engines. Therefore in the future as we retire in order along the > > engine timeline, we may retire out-of-order within a

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-24 Thread Tvrtko Ursulin
On 24/04/2018 15:46, Tvrtko Ursulin wrote: On 24/04/2018 14:14, Chris Wilson wrote: In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we may retire out-of-order within a ring (as the

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-24 Thread Tvrtko Ursulin
On 24/04/2018 14:14, Chris Wilson wrote: In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we may retire out-of-order within a ring (as the ring now occurs along multiple engines), lead

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-24 Thread Chris Wilson
Quoting Chris Wilson (2018-04-24 14:14:11) > In the next patch, rings are the central timeline as requests may jump > between engines. Therefore in the future as we retire in order along the > engine timeline, we may retire out-of-order within a ring (as the ring now > occurs along multiple engines

[Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-24 Thread Chris Wilson
In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we may retire out-of-order within a ring (as the ring now occurs along multiple engines), leading to much hilarity in miscomputing the pos

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-23 Thread Tvrtko Ursulin
On 23/04/2018 11:13, Chris Wilson wrote: In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we may retire out-of-order within a ring (as the ring now occurs along multiple engines), lead

[Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-23 Thread Chris Wilson
In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we may retire out-of-order within a ring (as the ring now occurs along multiple engines), leading to much hilarity in miscomputing the pos