Re: [Intel-gfx] [PATCH 2/5] drm/i915: preserve swizzle settings if necessary v3

2014-07-07 Thread Daniel Vetter
On Fri, Jun 27, 2014 at 09:15:25AM -0700, Steve Aarnio wrote: > On 06/11/2014 08:41 AM, Jesse Barnes wrote: > >On Wed, 11 Jun 2014 17:39:29 +0200 > >Daniel Vetter wrote: > > > >>On Wed, Jun 11, 2014 at 5:13 PM, Jesse Barnes > >>wrote: > - If you have a machine which uses tiled framebuffers a

Re: [Intel-gfx] [PATCH 2/5] drm/i915: preserve swizzle settings if necessary v3

2014-06-27 Thread Steve Aarnio
On 06/11/2014 08:41 AM, Jesse Barnes wrote: On Wed, 11 Jun 2014 17:39:29 +0200 Daniel Vetter wrote: On Wed, Jun 11, 2014 at 5:13 PM, Jesse Barnes wrote: - If you have a machine which uses tiled framebuffers and enables swizzling in the BIOS your code will a) drop the swizzle setup in g

Re: [Intel-gfx] [PATCH 2/5] drm/i915: preserve swizzle settings if necessary v3

2014-06-11 Thread Jesse Barnes
On Wed, 11 Jun 2014 17:39:29 +0200 Daniel Vetter wrote: > On Wed, Jun 11, 2014 at 5:13 PM, Jesse Barnes > wrote: > >> - If you have a machine which uses tiled framebuffers and enables > >> swizzling in the BIOS your code will a) drop the swizzle setup in > >> gem_init_hw, breaking resume b)

Re: [Intel-gfx] [PATCH 2/5] drm/i915: preserve swizzle settings if necessary v3

2014-06-11 Thread Daniel Vetter
On Wed, Jun 11, 2014 at 5:13 PM, Jesse Barnes wrote: >> - If you have a machine which uses tiled framebuffers and enables >> swizzling in the BIOS your code will a) drop the swizzle setup in >> gem_init_hw, breaking resume b) not set the swizzle settings correctly >> in swizzle_detect, break

Re: [Intel-gfx] [PATCH 2/5] drm/i915: preserve swizzle settings if necessary v3

2014-06-11 Thread Jesse Barnes
On Wed, 11 Jun 2014 11:23:26 +0200 Daniel Vetter wrote: > On Tue, Jun 10, 2014 at 12:45:38PM -0700, Jesse Barnes wrote: > > On Tue, 10 Jun 2014 21:33:27 +0200 > > Daniel Vetter wrote: > > > > > On Tue, Jun 10, 2014 at 7:27 PM, Jesse Barnes > > > wrote: > > > > Yes, that's what I do below... I

Re: [Intel-gfx] [PATCH 2/5] drm/i915: preserve swizzle settings if necessary v3

2014-06-11 Thread Daniel Vetter
On Tue, Jun 10, 2014 at 12:45:38PM -0700, Jesse Barnes wrote: > On Tue, 10 Jun 2014 21:33:27 +0200 > Daniel Vetter wrote: > > > On Tue, Jun 10, 2014 at 7:27 PM, Jesse Barnes > > wrote: > > > Yes, that's what I do below... I even added it to the changelog: > > > http://patchwork.freedesktop.org/p

Re: [Intel-gfx] [PATCH 2/5] drm/i915: preserve swizzle settings if necessary v3

2014-06-10 Thread Jesse Barnes
On Tue, 10 Jun 2014 21:33:27 +0200 Daniel Vetter wrote: > On Tue, Jun 10, 2014 at 7:27 PM, Jesse Barnes > wrote: > > Yes, that's what I do below... I even added it to the changelog: > > http://patchwork.freedesktop.org/patch/27223/ > > > > Did you miss the later hunk in intel_display.c? > > > >

Re: [Intel-gfx] [PATCH 2/5] drm/i915: preserve swizzle settings if necessary v3

2014-06-10 Thread Daniel Vetter
On Tue, Jun 10, 2014 at 7:27 PM, Jesse Barnes wrote: > Yes, that's what I do below... I even added it to the changelog: > http://patchwork.freedesktop.org/patch/27223/ > > Did you miss the later hunk in intel_display.c? > > What we try to do here is enable swizzling if possible, which we can do >

Re: [Intel-gfx] [PATCH 2/5] drm/i915: preserve swizzle settings if necessary v3

2014-06-10 Thread Jesse Barnes
On Tue, 10 Jun 2014 16:02:51 +0200 Daniel Vetter wrote: > On Thu, Jun 05, 2014 at 11:24:28AM -0700, Jesse Barnes wrote: > > Some machines (like MBAs) might use a tiled framebuffer but not enable > > display swizzling at boot time. We want to preserve that configuration > > if possible to prevent

Re: [Intel-gfx] [PATCH 2/5] drm/i915: preserve swizzle settings if necessary v3

2014-06-10 Thread Daniel Vetter
On Thu, Jun 05, 2014 at 11:24:28AM -0700, Jesse Barnes wrote: > Some machines (like MBAs) might use a tiled framebuffer but not enable > display swizzling at boot time. We want to preserve that configuration > if possible to prevent a boot time mode set. On IVB+ it shouldn't > affect performance

[Intel-gfx] [PATCH 2/5] drm/i915: preserve swizzle settings if necessary v3

2014-06-05 Thread Jesse Barnes
Some machines (like MBAs) might use a tiled framebuffer but not enable display swizzling at boot time. We want to preserve that configuration if possible to prevent a boot time mode set. On IVB+ it shouldn't affect performance anyway since the memory controller does internal swizzling anyway. Fo