Re: [Intel-gfx] [PATCH 2/5] drm/i915: make waiting trace events more useful

2012-05-02 Thread Daniel Vetter
On Wed, May 02, 2012 at 11:36:15PM +0200, Daniel Vetter wrote: > On Wed, May 02, 2012 at 10:22:33PM +0100, Chris Wilson wrote: > > On Wed, 2 May 2012 23:12:36 +0200, Daniel Vetter wrote: > > > For consistency I guess we can ditch the dev parameter (and even then, the > > > ring would uniquely iden

Re: [Intel-gfx] [PATCH 2/5] drm/i915: make waiting trace events more useful

2012-05-02 Thread Daniel Vetter
On Wed, May 02, 2012 at 10:22:33PM +0100, Chris Wilson wrote: > On Wed, 2 May 2012 23:12:36 +0200, Daniel Vetter wrote: > > For consistency I guess we can ditch the dev parameter (and even then, the > > ring would uniquely identify the device). Also, I guess you need to > > explicitly pass in bloc

Re: [Intel-gfx] [PATCH 2/5] drm/i915: make waiting trace events more useful

2012-05-02 Thread Chris Wilson
On Wed, 2 May 2012 23:12:36 +0200, Daniel Vetter wrote: > For consistency I guess we can ditch the dev parameter (and even then, the > ring would uniquely identify the device). Also, I guess you need to > explicitly pass in blocking, because mutex_is_locked is rather racy - > someone else could ho

Re: [Intel-gfx] [PATCH 2/5] drm/i915: make waiting trace events more useful

2012-05-02 Thread Daniel Vetter
On Mon, Apr 30, 2012 at 06:40:23PM -0700, Ben Widawsky wrote: > v2: Don't do a trace event per loop. (Chris) > Only get blocking/non-blocking info (Chris) > > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_trace.h | 22 -- > 1 file changed, 20 insertions(+),

[Intel-gfx] [PATCH 2/5] drm/i915: make waiting trace events more useful

2012-04-30 Thread Ben Widawsky
v2: Don't do a trace event per loop. (Chris) Only get blocking/non-blocking info (Chris) Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_trace.h | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gp

[Intel-gfx] [PATCH 2/5] drm/i915: make waiting trace events more useful

2012-04-29 Thread Ben Widawsky
With the new timeout parameter it is somewhat more useful to get trace events for each iteration of the loop with values we care about. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_gem.c |7 +++--- drivers/gpu/drm/i915/i915_trace.h | 45 +++--