Re: [Intel-gfx] [PATCH 2/5] drm/i915: WARN() if we can't lookup_power_well()

2018-08-23 Thread Imre Deak
On Mon, Aug 20, 2018 at 04:31:36PM -0700, Paulo Zanoni wrote: > None of the current lookup_power_well() callers are actually checking > for NULL return values, they all just use the pointer right away. The > first idea was to replace these theoretical segfaults with a BUG() > since this would at l

[Intel-gfx] [PATCH 2/5] drm/i915: WARN() if we can't lookup_power_well()

2018-08-20 Thread Paulo Zanoni
None of the current lookup_power_well() callers are actually checking for NULL return values, they all just use the pointer right away. The first idea was to replace these theoretical segfaults with a BUG() since this would at least make our code a little more explicit to the reader. It was sugges