Re: [Intel-gfx] [PATCH 2/4] drm/i915: clean up virtual PCH special case handling

2018-05-31 Thread Colin Xu
On 05/31/2018 07:56 PM, Jani Nikula wrote: Use intel_pch_type() also for mapping the no PCH case (PCH id 0) to PCH_NONE to simplify code. Also make sure that intel_pch_type() knows all the PCH ids returned by intel_virt_detect_pch(). Loudly fail if this isn't the case; this shouldn't happen anyw

[Intel-gfx] [PATCH 2/4] drm/i915: clean up virtual PCH special case handling

2018-05-31 Thread Jani Nikula
Use intel_pch_type() also for mapping the no PCH case (PCH id 0) to PCH_NONE to simplify code. Also make sure that intel_pch_type() knows all the PCH ids returned by intel_virt_detect_pch(). Loudly fail if this isn't the case; this shouldn't happen anyway. Cc: Colin Xu Reviewed-by: Ville Syrjälä