Re: [Intel-gfx] [PATCH 2/4] drm/i915: clarify preferred sdvo input mode code

2012-05-22 Thread Daniel Vetter
On Tue, Apr 10, 2012 at 01:18:13PM +0100, Chris Wilson wrote: > On Tue, 10 Apr 2012 13:55:47 +0200, Daniel Vetter > wrote: > > - kill intel_sdvo->input_dtd, it's only used as a temporary variable, > > we store the preferred input mode in the adjusted mode at mode_fixup > > time. > > - rename

Re: [Intel-gfx] [PATCH 2/4] drm/i915: clarify preferred sdvo input mode code

2012-04-10 Thread Chris Wilson
On Tue, 10 Apr 2012 13:55:47 +0200, Daniel Vetter wrote: > - kill intel_sdvo->input_dtd, it's only used as a temporary variable, > we store the preferred input mode in the adjusted mode at mode_fixup > time. > - rename the function to make it clear what we want it to do (get the > preferred

[Intel-gfx] [PATCH 2/4] drm/i915: clarify preferred sdvo input mode code

2012-04-10 Thread Daniel Vetter
- kill intel_sdvo->input_dtd, it's only used as a temporary variable, we store the preferred input mode in the adjusted mode at mode_fixup time. - rename the function to make it clear what we want it to do (get the preferred mode) and say in a comment what it unfortunately does as a side-ef