Re: [Intel-gfx] [PATCH 2/4] drm/i915: Retire requests along rings

2018-04-23 Thread Tvrtko Ursulin
On 23/04/2018 10:06, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-23 09:47:57) On 20/04/2018 14:20, Chris Wilson wrote: void i915_retire_requests(struct drm_i915_private *i915) { - struct intel_engine_cs *engine; - enum intel_engine_id id; + struct intel_ring *ring,

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Retire requests along rings

2018-04-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-23 09:47:57) > > On 20/04/2018 14:20, Chris Wilson wrote: > > void i915_retire_requests(struct drm_i915_private *i915) > > { > > - struct intel_engine_cs *engine; > > - enum intel_engine_id id; > > + struct intel_ring *ring, *next; > > > > l

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Retire requests along rings

2018-04-23 Thread Tvrtko Ursulin
On 20/04/2018 14:20, Chris Wilson wrote: In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we may retire out-of-order within a ring (as the ring now occurs along multiple engines), lead

[Intel-gfx] [PATCH 2/4] drm/i915: Retire requests along rings

2018-04-20 Thread Chris Wilson
In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we may retire out-of-order within a ring (as the ring now occurs along multiple engines), leading to much hilarity in miscomputing the pos