Re: [Intel-gfx] [PATCH 2/4] drm/i915: Only mark the execobject as pinned on success

2017-07-24 Thread Joonas Lahtinen
On pe, 2017-07-21 at 15:50 +0100, Chris Wilson wrote: > If we fail to acquire a fence (for old school fenced GPU access) then we > unwind the vma reservation, including its pin. However, we were making > the execobject as holding the pin before erring out, leading to a double > unpin: > > [ 3193.9

[Intel-gfx] [PATCH 2/4] drm/i915: Only mark the execobject as pinned on success

2017-07-21 Thread Chris Wilson
If we fail to acquire a fence (for old school fenced GPU access) then we unwind the vma reservation, including its pin. However, we were making the execobject as holding the pin before erring out, leading to a double unpin: [ 3193.991802] kernel BUG at drivers/gpu/drm/i915/i915_vma.h:287! [ 3193.9