Re: [Intel-gfx] [PATCH 2/4] drm/i915: Lookup CRTC for plane directly

2015-04-09 Thread Matt Roper
On Thu, Apr 09, 2015 at 02:44:05PM +0200, Daniel Vetter wrote: > On Wed, Apr 08, 2015 at 06:56:52PM -0700, Matt Roper wrote: > > Various places in the atomic plane code obtain the CRTC via > > plane_state->crtc. But plane_state->crtc is NULL when disabling the > > plane, so the code will fall back

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Lookup CRTC for plane directly

2015-04-09 Thread Daniel Vetter
On Wed, Apr 08, 2015 at 06:56:52PM -0700, Matt Roper wrote: > Various places in the atomic plane code obtain the CRTC via > plane_state->crtc. But plane_state->crtc is NULL when disabling the > plane, so the code will fall back to looking at the old CRTC value in > plane->crtc in that case. This

[Intel-gfx] [PATCH 2/4] drm/i915: Lookup CRTC for plane directly

2015-04-08 Thread Matt Roper
Various places in the atomic plane code obtain the CRTC via plane_state->crtc. But plane_state->crtc is NULL when disabling the plane, so the code will fall back to looking at the old CRTC value in plane->crtc in that case. This isn't going to work when we start supporting non-blocking flips (sin